feat: add RPC limit for sync_nullifiers
#1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasArrachea
force-pushed
the
tomasarrachea-sync-nullifiers-limit
branch
from
a85a7a9 to
d8c9cf7
Compare
TomasArrachea
commented
Dec 4, 2025
Comment on lines
-444
to
-448
| if !seen_nullifiers.insert(nullifier_update.nullifier) { | ||
| return Err(RpcError::InvalidResponse( | ||
| "duplicate nullifier found in response".to_string(), | ||
| )); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This check made the sync_nullifiers to error if a duplicate nullifier was received. Now we just ignore duplicates, since that might happen when processing a chunk that contains a nullifier that collides with a nullifier handled previously,
SantiagoPittella
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1139
This PR modifies the
sync_nullifiersimplementation on the TonicRpcClient to chunk the requested nullifiers and then aggregate the response, to avoid violating the RPC limit set on the node.