Skip to content

Conversation

@JillRegan
Copy link
Contributor

@JillRegan JillRegan commented Dec 4, 2025

✨ Summary

  • We updated the provider to use 1Password SDKs which has resolved this issue. There was logic issue with the CLI parsing the password recipe data, which now does not apply as it has been deprecated.
  • I have added E2E coverage here to ensure categories that allow password recipes all work as expected.

🔗 Resolves:

#129

✅ Checklist

  • 🖊️ Commits are signed
  • 🧪 Tests added/updated: (See the Testing Guide for when to use each type and how to run them)
    • 🔹 Unit /🔸 Integration
    • 🌐 E2E
  • 📚 Docs updated (if behavior changed)

🕵️ Review Notes & ⚠️ Risks

@JillRegan JillRegan changed the title [DRAFT] Add E2E test for password generation per category Add E2E test for password generation per category Dec 5, 2025
@JillRegan JillRegan marked this pull request as ready for review December 5, 2025 13:42
@JillRegan JillRegan merged commit 9a2da7a into main Dec 5, 2025
10 of 11 checks passed
@JillRegan JillRegan deleted the jill/add-e2e-test-for-category-password-generation branch December 5, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants