-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add various quick searches #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hovudstraum
Are you sure you want to change the base?
Conversation
| #ops { | ||
| padding: .3em .6em; | ||
| white-space: nowrap; | ||
| display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to make the filter input vertically centered
| text-shadow: 1px 1px 1px var(--op-a-sh); | ||
| font-size: 1.5em; | ||
| padding: .25em .4em; | ||
| padding: 0em .4em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to preserve the old look after adding flex to #ops
|
|
||
| #opa_filter { | ||
| margin: 0em .4em; | ||
| min-width: 50px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default min-width makes this go out of screen on mobile
| "ct_idxh": 'vis index.html istedenfor fil-liste">htm', | ||
| "ct_sbars": 'vis rullgardiner / skrollefelt">⟊', | ||
|
|
||
| "qs_off": 'deaktiver hurtigsøk, hurtigtaster vil fungere">av', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI translated, please verify
| "ct_idxh": '显示 index.html 代替文件夹列表">htm', | ||
| "ct_sbars": '显示滚动条">⟊', | ||
|
|
||
| "qs_off": '禁用快速搜索,热键将正常工作">关闭', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI translated, please verify
| ); | ||
|
|
||
| // Bind quicksearch setting to UI | ||
| (function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get bcfg_bind to work, feel free to simplify if possible
| if (aet && aet != 'a' && aet != 'tr' && aet != 'td' && aet != 'div' && aet != 'pre') | ||
| return; | ||
|
|
||
| if (handle_qsearch_key(e)) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placement of this is very tricky, but I think this should be right? Please verify
|
really cool tech demo! but I think it would be even more practical if it behaved like firefox's built-in quicksearch;
that way,
this would make it possible to keep hotkeys enabled in all of the quicksearch modes, and we could just read the value of the textbox instead of keeping track of the input manually, allowing for full editing / seeing typos. and then we could redefine mode 0 to entirely hide the Filter-box, since some people may prefer saving the screen space (old iphones are way cramped). And firefox users will probably prefer this too, since they already have quicksearch :> some general feedback:
as for machine-translated chinese, adding a |
TODO, just putting this up for early testing and feedback.
output.mov