From 19bb89874e915017fe40a7ad9490e9a56401719e Mon Sep 17 00:00:00 2001 From: Xavier Ruiz Date: Sat, 27 Dec 2025 18:00:38 -0500 Subject: [PATCH] fix(cava): default data_format to ascii for correct bar scaling data_format was changed from always "ascii" to user-configurable, but without a default. This caused cava to use "binary", calculating height as 65535 instead of ascii_range, making bars always peak. --- src/modules/cava/cava_backend.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/cava/cava_backend.cpp b/src/modules/cava/cava_backend.cpp index 917e165fa..c576f0cfc 100644 --- a/src/modules/cava/cava_backend.cpp +++ b/src/modules/cava/cava_backend.cpp @@ -183,10 +183,10 @@ void waybar::modules::cava::CavaBackend::loadConfig() { prm_.inAtty = 0; auto const output{prm_.output}; // prm_.output = ::cava::output_method::OUTPUT_RAW; - if (config_["data_format"].isString()) { - if (prm_.data_format) free(prm_.data_format); - prm_.data_format = strdup(config_["data_format"].asString().c_str()); - } + if (prm_.data_format) free(prm_.data_format); + // Default to ascii for format-icons output; allow user override + prm_.data_format = strdup( + config_["data_format"].isString() ? config_["data_format"].asString().c_str() : "ascii"); if (config_["raw_target"].isString()) { if (prm_.raw_target) free(prm_.raw_target); prm_.raw_target = strdup(config_["raw_target"].asString().c_str());