Stop Pump When Input Dry Logic is inverted

[nofuturekid]

The logic for the prevention of dry-running is not working correctly.

If there is water in the bottle, the sensor for "fluid_input_sensor" is "on" and so the pump will not even start because of the last
"if" condition.

  - id: pump_safety_check
    mode: restart
    then:
      - while:
          condition:
            - switch.is_on: pump_control
          then:
            - if:
                condition:
                  - and:
                      - switch.is_on: stop_pump_when_full
                      - binary_sensor.is_on: fulid_output_sensor
                then:
                  - logger.log: "Pump stopping - tank full"
                  - switch.turn_off: pump_control
            - if:
                condition:
                  - lambda: |-
                      if (id(pump_start_time) == 0) return false;
                      uint32_t runtime = (millis() - id(pump_start_time)) / 1000;
                      return runtime > id(max_safe_run_time).state && !id(pump_safety_override).state;
                then:
                  - logger.log: "Pump stopping - safety"
                  - switch.turn_off: pump_control
            - if:
                condition:
                  - and:
                      - switch.is_on: stop_pump_when_dry
                      - binary_sensor.is_on: fluid_input_sensor
                then:
                  - logger.log: "Pump stopping - input dry"
                  - switch.turn_off: pump_control
            - delay: 1s

[bharvey88]

The logic for the prevention of dry-running is not working correctly.

If there is water in the bottle, the sensor for "fluid_input_sensor" is "on" and so the pump will not even start because of the last "if" condition.

  - id: pump_safety_check
    mode: restart
    then:
      - while:
          condition:
            - switch.is_on: pump_control
          then:
            - if:
                condition:
                  - and:
                      - switch.is_on: stop_pump_when_full
                      - binary_sensor.is_on: fulid_output_sensor
                then:
                  - logger.log: "Pump stopping - tank full"
                  - switch.turn_off: pump_control
            - if:
                condition:
                  - lambda: |-
                      if (id(pump_start_time) == 0) return false;
                      uint32_t runtime = (millis() - id(pump_start_time)) / 1000;
                      return runtime > id(max_safe_run_time).state && !id(pump_safety_override).state;
                then:
                  - logger.log: "Pump stopping - safety"
                  - switch.turn_off: pump_control
            - if:
                condition:
                  - and:
                      - switch.is_on: stop_pump_when_dry
                      - binary_sensor.is_on: fluid_input_sensor
                then:
                  - logger.log: "Pump stopping - input dry"
                  - switch.turn_off: pump_control
            - delay: 1s

Thank you for submitting this issue and pointing us to the fix - we really appreciate it! I have just submitted a PR to fix this and it should be in the beta branch then main branch soonTM. you can test the fix for now using this yaml to switch to the fix-input-dry-logic branch:

packages:
  ApolloAutomation.PUMP-1: # name of package/project
    url: https://github.com/ApolloAutomation/PUMP-1 # url of the repository
    ref: fix-input-dry-logic # branch, tag or commit SHA
    files: [Integrations/ESPHome/PUMP-1_Minimal.yaml] # Path to config from base repo URL
    refresh: 0s # how often to sync updates from the remote url

[bharvey88]

I'm going to close the issue as solved - let me know if you run into any issues testing the fix-input-dry-logic branch. Thanks again for helping.