fix issue #9; add notice for windows udp/tcp tracerouting

Author: Archeb

MainForm.cs

@@ -8,6 +8,7 @@
 using NextTrace;
 using System.Net;
 using Newtonsoft.Json;
+using System.Runtime.InteropServices;
 
 namespace OpenTrace
 {
@@ -107,7 +108,8 @@ public MainForm()
 
             mapWebView = new WebView
             {
-                Url = new Uri("https://lbs.baidu.com/jsdemo/demo/webgl0_0.htm")
+                Url = new Uri("https://lbs.baidu.com/jsdemo/demo/webgl0_0.htm"),
+                
             };
 
             // 绑定控件事件
@@ -118,7 +120,7 @@ public MainForm()
             tracerouteGridView.MouseUp += Dragging_MouseUp;
             tracerouteGridView.SelectedRowsChanged += TracerouteGridView_SelectedRowsChanged;
             startTracerouteButton.Click += StartTracerouteButton_Click;
-            HostInputBox.KeyUp += HostInputBox_KeyUp;
+            HostInputBox.KeyDown += HostInputBox_KeyDown;
             HostInputBox.TextChanged += HostInputBox_TextChanged;
             MTRMode.CheckedChanged += MTRMode_CheckedChanged;
 
@@ -184,9 +186,9 @@ private void MTRMode_CheckedChanged(object sender, EventArgs e)
             }
         }
 
-        private void HostInputBox_KeyUp(object sender, KeyEventArgs e)
+        private void HostInputBox_KeyDown(object sender, KeyEventArgs e)
         {
-            if(e.Key == Keys.Enter)
+            if (e.Key == Keys.Enter)
             {
                 if (CurrentInstance != null)  StopTraceroute();
                 StartTracerouteButton_Click(sender, e);
@@ -200,6 +202,11 @@ private void TracerouteGridView_SelectedRowsChanged(object sender, EventArgs e)
 
         private void StartTracerouteButton_Click(object sender, EventArgs e)
         {
+            if(protocolSelection.SelectedValue.ToString() != "ICMP" && RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                MessageBox.Show(Resources.WINDOWS_TCP_UDP_UNSUPPORTED);
+                return;
+            }
             if (CurrentInstance != null)
             {
                 StopTraceroute();
@@ -265,6 +272,7 @@ private void StartTracerouteButton_Click(object sender, EventArgs e)
                             HostInputBox.Text = uri.Host;
                         }
                         // 需要域名解析
+                        Title = Resources.APPTITLE + ": " + HostInputBox.Text;
                         IPAddress[] resolvedAddresses = Dns.GetHostAddresses(HostInputBox.Text);
                         if (resolvedAddresses.Length > 1)
                         {
@@ -287,11 +295,13 @@ private void StartTracerouteButton_Click(object sender, EventArgs e)
                     catch (System.Net.Sockets.SocketException)
                     {
                         MessageBox.Show(string.Format(Resources.NAME_NOT_RESOLVED, HostInputBox.Text), MessageBoxType.Warning);
+                        Title = Resources.APPTITLE;
                         return;
                     }
                     catch (Exception exception)
                     {
                         MessageBox.Show(exception.Message, MessageBoxType.Error);
+                        Title = Resources.APPTITLE;
                         return;
                     }
                 }
@@ -300,6 +310,7 @@ private void StartTracerouteButton_Click(object sender, EventArgs e)
             HostInputBox.Items.Insert(0, new ListItem { Text = HostInputBox.Text });
             CurrentInstance = instance;
             startTracerouteButton.Text = Resources.STOP;
+            int errorOutputCount = 0;
 
             ExceptionalOutputForm exceptionalOutputForm = new ExceptionalOutputForm();
 
@@ -334,6 +345,14 @@ private void StartTracerouteButton_Click(object sender, EventArgs e)
                     {
                         exceptionalOutputForm.Visible = true;
                     }
+                    if(errorOutputCount < 100)
+                    {
+                        errorOutputCount++;
+                    }
+                    else
+                    {
+                        StopTraceroute(); // 错误输出过多，强制结束
+                    }
                     exceptionalOutputForm.AppendOutput(e2.Output);
                 });
             };
@@ -363,10 +382,13 @@ private void StartTracerouteButton_Click(object sender, EventArgs e)
         }
         private void StopTraceroute()
         {
-            appForceExiting = true;
-            CurrentInstance.Kill();
-            startTracerouteButton.Text = Resources.START;
-            CurrentInstance = null;
+            if(CurrentInstance != null)
+            {
+                appForceExiting = true;
+                CurrentInstance.Kill();
+                startTracerouteButton.Text = Resources.START;
+                CurrentInstance = null;
+            }
         }
 
         /*

Properties/Resources.Designer.cs

@@ -342,6 +342,9 @@ Would you like to download the NextTrace utility now?</value>
   <data name="TRACEROUTING" xml:space="preserve">
     <value>Tracerouting</value>
   </data>
+  <data name="WINDOWS_TCP_UDP_UNSUPPORTED" xml:space="preserve">
+    <value>TCP/UDP Traceroute is not yet supported on Windows.</value>
+  </data>
   <data name="WORST" xml:space="preserve">
     <value>Worst</value>
   </data>

Properties/Resources.resx

@@ -336,6 +336,9 @@
   <data name="TRACEROUTING" xml:space="preserve">
     <value>路由追踪</value>
   </data>
+  <data name="WINDOWS_TCP_UDP_UNSUPPORTED" xml:space="preserve">
+    <value>Windows 暂不支持 TCP/UDP Traceroute</value>
+  </data>
   <data name="WORST" xml:space="preserve">
     <value>最差延迟</value>
   </data>

Properties/Resources.zh-CN.resx

@@ -29,7 +29,7 @@ window.opentrace = {
 			} catch (e) {}
 		}
 		if (pointlygon_array.length < 2) return;
-		var polygon = new BMapGL.Polyline(pointlygon_array, { strokeColor: "red", strokeWeight: 2, geodesic: true, strokeOpacity: 0.5 }); //创建折线
+		var polygon = new BMapGL.Polyline(pointlygon_array, { strokeColor: "red", strokeWeight: 2, strokeOpacity: 0.5 }); //创建折线
 		//Polyline（坐标值，{线段颜色，线段宽度，线段透明度}）；
 		map.addOverlay(polygon); //添加覆盖物
 		map.setViewport(pointlygon_array); //设置地图的中心点和缩放级别