(hopefully) fix silent crashes

Artikash · Artikash · commit 49432f689d2d · 2020-03-01T23:41:27.000-07:00
diff --git a/GUI/host/exception.cpp b/GUI/host/exception.cpp
@@ -22,8 +22,12 @@ namespace
 
 	__declspec(noreturn) void Terminate()
 	{
-		MessageBoxW(NULL, lastError.c_str(), L"Textractor ERROR", MB_ICONERROR);
-		abort();
+		CreateThread(nullptr, 0, [](void* lastError) -> DWORD
+		{
+			MessageBoxW(NULL, (wchar_t*)lastError, L"Textractor ERROR", MB_ICONERROR); // might fail to display if called in main thread and exception was in main event loop
+			abort();
+		}, lastError.data(), 0, nullptr);
+		Sleep(MAXDWORD);
 	}
 
 	LONG WINAPI ExceptionLogger(EXCEPTION_POINTERS* exception)

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,12 @@ namespace`
`22`	`22`
`23`	`23`	`__declspec(noreturn) void Terminate()`
`24`	`24`	`{`
`25`		`- MessageBoxW(NULL, lastError.c_str(), L"Textractor ERROR", MB_ICONERROR);`
`26`		`- abort();`
	`25`	`+ CreateThread(nullptr, 0, [](void* lastError) -> DWORD`
	`26`	`+ {`
	`27`	`+ MessageBoxW(NULL, (wchar_t*)lastError, L"Textractor ERROR", MB_ICONERROR); // might fail to display if called in main thread and exception was in main event loop`
	`28`	`+ abort();`
	`29`	`+ }, lastError.data(), 0, nullptr);`
	`30`	`+ Sleep(MAXDWORD);`
`27`	`31`	`}`
`28`	`32`
`29`	`33`	`LONG WINAPI ExceptionLogger(EXCEPTION_POINTERS* exception)`