fix types

Author: dhasilva

projects/packages/forms/src/dashboard/components/response-actions/index.tsx

@@ -20,9 +20,10 @@ import {
  * Types
  */
 import type { FormResponse } from '../../../types';
+import type { Registry } from '../../inbox/dataviews/types';
 
 type ResponseNavigationProps = {
-	onActionComplete?: ( FormResponse ) => void;
+	onActionComplete?: ( response: FormResponse ) => void;
 	response: FormResponse;
 };
 
@@ -37,7 +38,7 @@ const ResponseActions = ( {
 	const [ isDeleting, setIsDeleting ] = useState( false );
 	const [ isTogglingReadStatus, setIsTogglingReadStatus ] = useState( false );
 
-	const registry = useRegistry();
+	const registry = useRegistry() as unknown as Registry;
 
 	const handleMarkAsSpam = useCallback( async () => {
 		onActionComplete?.( response );

projects/packages/forms/src/dashboard/inbox/dataviews/types.tsx

@@ -1,3 +1,4 @@
+import type { FormResponse } from '../../../types';
 import type { StoreDescriptor } from '@wordpress/data';
 
 /**
@@ -14,7 +15,7 @@ export type QueryParams = {
 /**
  * Store actions
  */
-type Registry = {
+export type Registry = {
 	dispatch: ( store: StoreDescriptor ) => {
 		// Notices store actions
 		createSuccessNotice: (
@@ -35,14 +36,14 @@ type Registry = {
 		deleteEntityRecord: (
 			kind: string,
 			name: string,
-			recordId: string,
+			recordId: number,
 			query: Record< string, unknown >,
 			options?: { throwOnError?: boolean }
 		) => Promise< void >;
 		editEntityRecord: (
 			kind: string,
 			name: string,
-			recordId: string,
+			recordId: number,
 			edits: Record< string, unknown >
 		) => Promise< void >;
 
@@ -56,7 +57,7 @@ type Registry = {
 		doBulkAction: ( ids: string[], action: string ) => void;
 		invalidateFilters: () => void;
 		invalidateCounts: () => void;
-		markRecordsAsInvalid: ( ids: string[] ) => void;
+		markRecordsAsInvalid: ( ids: number[] ) => void;
 	};
 	select: ( store: StoreDescriptor ) => {
 		// Dashboard store select actions
@@ -66,25 +67,18 @@ type Registry = {
 		getEntityRecord: (
 			kind: string,
 			name: string,
-			recordId: string
+			recordId: number
 		) => Record< string, unknown > | undefined;
 	};
 };
 
-type Item = {
-	id: string;
-	status: string;
-	edit_form_url: string;
-	is_unread: boolean;
-};
-
 export type Action = {
 	id: string;
 	isPrimary: boolean;
 	icon: React.ReactNode;
 	label: string;
 	modalHeader?: string;
-	isEligible?: ( item: Item ) => boolean;
+	isEligible?: ( item: FormResponse ) => boolean;
 	supportsBulk?: boolean;
-	callback?: ( items: Item[], { registry }: { registry: Registry } ) => Promise< void >;
+	callback?: ( items: FormResponse[], { registry }: { registry: Registry } ) => Promise< void >;
 };

projects/packages/forms/src/types/index.ts

@@ -114,6 +114,8 @@ export interface FormResponse {
 	is_unread: boolean;
 	/** The fields of the response. */
 	fields: Record< string, unknown >;
+	/** The URL to edit the form that the response was submitted to. */
+	edit_form_url: string;
 }
 
 /**