Skip to content

Commit 139090e

Browse files
committed
resolved copilot comments
1 parent c5fb7ef commit 139090e

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/RedoAzureRmRecoveryServicesBackupProtection.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ public override void ExecuteCmdlet()
6666
base.ExecuteCmdlet();
6767
PsBackupProviderManager providerManager;
6868
JobBase jobObj = null;
69-
70-
// chck with nandini, source vault is default and can we name targetvault ?
69+
7170
ResourceIdentifier resourceIdentifier = new ResourceIdentifier(VaultId);
7271
string vaultName = resourceIdentifier.ResourceName;
7372
string resourceGroupName = resourceIdentifier.ResourceGroupName;
@@ -149,7 +148,7 @@ public override void ExecuteCmdlet()
149148

150149
// Step 3: Configure backup in target vault
151150
WriteVerbose("Configuring backup in target vault now");
152-
// chck : switch context to the target vault's subscription
151+
// TODO : switch context to the target vault's subscription
153152

154153
// Create provider manager for target vault with workload-specific parameters
155154
Dictionary<Enum, object> targetProviderParams = new Dictionary<Enum, object>()
@@ -190,7 +189,7 @@ public override void ExecuteCmdlet()
190189
{
191190
// For AzureFiles: extract file share name and storage account name
192191
AzureFileShareItem afsItem = (AzureFileShareItem)Item;
193-
string fileShareName = afsItem.FriendlyName; // do we need name here?
192+
string fileShareName = afsItem.FriendlyName;
194193
string storageAccountName = BackupUtils.GetStorageAccountNameFromContainerName(afsItem.ContainerName);
195194

196195
targetProviderParams.Add(ItemParams.ItemName, fileShareName);

src/RecoveryServices/RecoveryServices.Backup/Helpers/CmdletHelper.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,16 @@ public static bool IsContainerUnregistrationRequired(CmdletModel.ContainerType c
4242

4343
public static string GetContainerNameFromItem(ItemBase item)
4444
{
45+
// container name format for SQL and AFS
46+
// StorageContainer;Storage;rgname;afsname
47+
// VMAppContainer;Compute;RGName;vmanme
4548
return item.ContainerName;
4649
}
4750

4851
public static JobBase UnregisterContainer(ItemBase item, string vaultName, string resourceGroupName, ServiceClientAdapter serviceClientAdapter, RSBackupVaultCmdletBase rsBackupVaultCmdletBase)
4952
{
5053
string containerName = GetContainerNameFromItem(item);
51-
// chck: verify if this is the correct format for SQL and AFS workloads
52-
// StorageContainer;Storage;rgname;afsname
53-
// VMAppContainer;Compute;RGName;vmanme
54-
54+
5555
Logger.Instance.WriteDebug("Unregistering Azure Storage container: " + containerName);
5656
try
5757
{
@@ -158,7 +158,7 @@ public static ProtectableItemBase GetMatchingProtectableItem(ItemBase item, stri
158158
Logger.Instance.WriteDebug("proItemName: " + ((AzureWorkloadProtectableItem)itemModel).Name +
159159
", proItemContainerName: " + ((AzureWorkloadProtectableItem)itemModel).ContainerName);
160160

161-
return (string.Compare(((AzureWorkloadProtectableItem)itemModel).Name, item.Name,true) == 0
161+
return (string.Compare(((AzureWorkloadProtectableItem)itemModel).Name, item.Name, true) == 0
162162
&& string.Compare(((AzureWorkloadProtectableItem)itemModel).ContainerName, item.ContainerName, true) == 0);
163163
}).ToList();
164164
}
@@ -168,7 +168,7 @@ public static ProtectableItemBase GetMatchingProtectableItem(ItemBase item, stri
168168
return null;
169169
}
170170

171-
if(itemModels!= null && itemModels.Count > 0)
171+
if(itemModels != null && itemModels.Count > 0)
172172
{
173173
return itemModels[0];
174174
}

0 commit comments

Comments
 (0)