-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Migrate ConnectedKubernetes from generation to main #26104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
❌Az.ConnectedKubernetes
|
|
@msJinLei This PR misses the change added exception in static analysis and fails the pipeline xw-zhang24@3795689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate ConnectedKubernetes from generation to main
The last commit of src/ConnectedKubernetes in generation is:
commit 7eb813d Author: xw-zhang24 [email protected] Date: Sun Sep 15 15:45:20 2024 +0100 Update cmdlet to support arc gateway (#26026) * move changes in custom folders * Confirm new branch created. * Initial UTs. * More testing. * Get Azure Metadata improved. * Improve endpoint handling. * Clean up some jsonifiction * Testing getting DP to work. * It does create an ARC proxy now. * Removed 'debugging' error logs. * replace param names * Handle runing tests in autorest Docker. * Always use default config DP endpoint. * save work before pull * Hide internal functions. * Hide intenal functions. * Hide intenal functions. * Remove unused AD resource ID. * Remove last of !!PDS markers. * removing unnecessary option * Get unit tests working again and rename internal functions back. * add verbose logging to New command * add verbose logging to helmhelper * add set block * put inputobject back * work on comments * work on comments * Name mismatch. * regenerate files after merge * Internal function name mismatch. * Add some development notes. * fixes * Updates from suggestions from Xiwen. * verbose markups * Revert "verbose markups" This reverts commit 72f4bb9. * actual verbose markups * get helm before upgrade * now we have set scripts * remove ConnectionType * why connectiontype is still here? * why connectiontype is still here? * verbose logging for Set command * regenerate files * remove comments * remove extraction comments * remove comments * remove set with inputobject again * extract common code from New and Set * new helper file with common code * Rename common file. * Should work for New now. * move common code to helm helper * return hashtable * only parse when not provided * set DisableGateway to not EnableGatway * introduce extra paramtersets for enable/disable gateway * move parameters up * Typo in parameter set name. * Placeholder comment. * Generalize ConfigDP mapping support in New - DOES NOT WORK yet. * deal with protected settings * Updated comments on ConfigDP and name matching. * Comment string describing the configuration settings check. * Updated comments for configuration settings parameters. * Only pass settings to CCRP. * Create empty hash tables not null if no values. * deal with protected setting in Set- * Commonalize some methods. * Commonalize some methods. * Add ShouldProcess support for New-... * fix 1 * fix: exclude indices in function return * should process set * Cannot manipulate PSBoundParameters in sub-function. * Initialize health DP status code. * What-If processing. Use approved verb for Confim-HelmVersion. * Enable helm debugging if -Debug is set. * Make tests work again Move method to ConfigDP helper. * what if on Set * remove some comments * remove commented code * Use old ClientKnown redacted variant. * Use old ClientKnown redacted variant. * Remove feature warnings Correct bug setting helm debug option. * use colon as delimiter in configration setting * clean up * rename helper file * Make docs autogen work. * renaming AZCloudMetadataHelper to AzCloudMetadataHelper * fix url * add examples * singular nouns * add exception * send protected settings * fix index in Set and string finding in both Set and New * reorder options --------- Co-authored-by: Paul D.Smith [email protected] Co-authored-by: Benhur Johnson [email protected] Co-authored-by: Lei jin [email protected]
Checklist