Skip to content

Conversation

@azure-pipelines
Copy link
Contributor

Description

Migrate ConnectedKubernetes from generation to main
The last commit of src/ConnectedKubernetes in generation is:
commit 7eb813d Author: xw-zhang24 [email protected] Date: Sun Sep 15 15:45:20 2024 +0100 Update cmdlet to support arc gateway (#26026) * move changes in custom folders * Confirm new branch created. * Initial UTs. * More testing. * Get Azure Metadata improved. * Improve endpoint handling. * Clean up some jsonifiction * Testing getting DP to work. * It does create an ARC proxy now. * Removed 'debugging' error logs. * replace param names * Handle runing tests in autorest Docker. * Always use default config DP endpoint. * save work before pull * Hide internal functions. * Hide intenal functions. * Hide intenal functions. * Remove unused AD resource ID. * Remove last of !!PDS markers. * removing unnecessary option * Get unit tests working again and rename internal functions back. * add verbose logging to New command * add verbose logging to helmhelper * add set block * put inputobject back * work on comments * work on comments * Name mismatch. * regenerate files after merge * Internal function name mismatch. * Add some development notes. * fixes * Updates from suggestions from Xiwen. * verbose markups * Revert "verbose markups" This reverts commit 72f4bb9. * actual verbose markups * get helm before upgrade * now we have set scripts * remove ConnectionType * why connectiontype is still here? * why connectiontype is still here? * verbose logging for Set command * regenerate files * remove comments * remove extraction comments * remove comments * remove set with inputobject again * extract common code from New and Set * new helper file with common code * Rename common file. * Should work for New now. * move common code to helm helper * return hashtable * only parse when not provided * set DisableGateway to not EnableGatway * introduce extra paramtersets for enable/disable gateway * move parameters up * Typo in parameter set name. * Placeholder comment. * Generalize ConfigDP mapping support in New - DOES NOT WORK yet. * deal with protected settings * Updated comments on ConfigDP and name matching. * Comment string describing the configuration settings check. * Updated comments for configuration settings parameters. * Only pass settings to CCRP. * Create empty hash tables not null if no values. * deal with protected setting in Set- * Commonalize some methods. * Commonalize some methods. * Add ShouldProcess support for New-... * fix 1 * fix: exclude indices in function return * should process set * Cannot manipulate PSBoundParameters in sub-function. * Initialize health DP status code. * What-If processing. Use approved verb for Confim-HelmVersion. * Enable helm debugging if -Debug is set. * Make tests work again Move method to ConfigDP helper. * what if on Set * remove some comments * remove commented code * Use old ClientKnown redacted variant. * Use old ClientKnown redacted variant. * Remove feature warnings Correct bug setting helm debug option. * use colon as delimiter in configration setting * clean up * rename helper file * Make docs autogen work. * renaming AZCloudMetadataHelper to AzCloudMetadataHelper * fix url * add examples * singular nouns * add exception * send protected settings * fix index in Set and string finding in both Set and New * reorder options --------- Co-authored-by: Paul D.Smith [email protected] Co-authored-by: Benhur Johnson [email protected] Co-authored-by: Lei jin [email protected]

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 15, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.ConnectedKubernetes
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Signature Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
Set-AzConnectedKubernetes Set-AzConnectedKubernetes uses the noun 'AzConnectedKubernetes', which does not follow the enforced naming convention of using a singular noun for a cmdlet name. Consider using a singular noun for the cmdlet name.
❌Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
Set-AzConnectedKubernetes Set-AzConnectedKubernetes uses the noun 'AzConnectedKubernetes', which does not follow the enforced naming convention of using a singular noun for a cmdlet name. Consider using a singular noun for the cmdlet name.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedKubernetes 4 2 Mismatched_Parameter_Value_Type Get-AzConnectedKubernetes -InputObject $conAks is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.IConnectedKubernetesIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.Api20240715Preview.IConnectedCluster.(Command).
⚠️ Get-AzConnectedKubernetes 4 2 Mismatched_Parameter_Value_Type Get-AzConnectedKubernetes -InputObject $conAks is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.IConnectedKubernetesIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.Api20240715Preview.IConnectedCluster.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedKubernetes 4 2 Mismatched_Parameter_Value_Type Get-AzConnectedKubernetes -InputObject $conAks is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.IConnectedKubernetesIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.Api20240715Preview.IConnectedCluster.(Command).
⚠️ Get-AzConnectedKubernetes 4 2 Mismatched_Parameter_Value_Type Get-AzConnectedKubernetes -InputObject $conAks is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.IConnectedKubernetesIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedKubernetes.Models.Api20240715Preview.IConnectedCluster.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedKubernetes. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedKubernetes. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00 % 60.00% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00% 60.00% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00% 60.00% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00% 60.00% Test coverage cannot be lower than the number of the last release.

@xw-zhang24
Copy link

xw-zhang24 commented Sep 16, 2024

@msJinLei This PR misses the change added exception in static analysis and fails the pipeline xw-zhang24@3795689

@msJinLei msJinLei closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants