chore: add enable v1alpha1 flag back for backward compatibility with CCP (#344)

* add enable v1alpha1 flag back for backward compatibility

* return error if v1alpha1 is enabled

Signed-off-by: Wei Weng <[email protected]>

---------

Signed-off-by: Wei Weng <[email protected]>
Co-authored-by: Wei Weng <[email protected]>

Author: weng271190436

cmd/mcs-controller-manager/main.go

@@ -8,6 +8,7 @@ package main
 
 import (
 	"context"
+	"errors"
 	"flag"
 	"os"
 	"os/signal"
@@ -60,7 +61,9 @@ var (
 	tlsClientInsecure    = flag.Bool("tls-insecure", false, "Enable TLSClientConfig.Insecure property. Enabling this will make the connection inSecure (should be 'true' for testing purpose only.)")
 	fleetSystemNamespace = flag.String("fleet-system-namespace", "fleet-system", "The reserved system namespace used by fleet.")
 
-	isV1Beta1APIEnabled = flag.Bool("enable-v1beta1-apis", true, "If set, the agents will watch for the v1beta1 APIs.")
+	// TODO(weiweng): remove fleet v1alpha1 flag after references was removed elsewhere.
+	isV1Alpha1APIEnabled = flag.Bool("enable-v1alpha1-apis", false, "If set, the agents will watch for the v1alpha1 APIs. This flag is deprecated and will be removed in future releases.")
+	isV1Beta1APIEnabled  = flag.Bool("enable-v1beta1-apis", true, "If set, the agents will watch for the v1beta1 APIs.")
 
 	enableNetworkingFeatures = flag.Bool("enable-networking-features", true, "If set, the networking features will be enabled. When disabled, only heartbeat functionality is preserved.")
 )
@@ -247,6 +250,11 @@ func setupControllersWithManager(_ context.Context, hubMgr, memberMgr manager.Ma
 	memberClient := memberMgr.GetClient()
 	hubClient := hubMgr.GetClient()
 
+	if *isV1Alpha1APIEnabled {
+		klog.Error("Fleet v1alpha1 flag is set to true, but this flag is deprecated and will be removed in future releases")
+		return errors.New("v1alpha1 APIs are deprecated and no longer supported, please use v1beta1 APIs instead")
+	}
+
 	if *isV1Beta1APIEnabled {
 		klog.V(1).InfoS("Create internalmembercluster (v1beta1 API) reconciler")
 		if err := (&imcv1beta1.Reconciler{

cmd/member-net-controller-manager/main.go

@@ -9,6 +9,7 @@ package main
 
 import (
 	"context"
+	"errors"
 	"flag"
 	"fmt"
 	"os"
@@ -70,7 +71,9 @@ var (
 	tlsClientInsecure    = flag.Bool("tls-insecure", false, "Enable TLSClientConfig.Insecure property. Enabling this will make the connection inSecure (should be 'true' for testing purpose only.)")
 	fleetSystemNamespace = flag.String("fleet-system-namespace", "fleet-system", "The reserved system namespace used by fleet.")
 
-	isV1Beta1APIEnabled = flag.Bool("enable-v1beta1-apis", true, "If set, the agents will watch for the v1beta1 APIs.")
+	// TODO(weiweng): remove fleet v1alpha1 flag after references was removed elsewhere.
+	isV1Alpha1APIEnabled = flag.Bool("enable-v1alpha1-apis", false, "If set, the agents will watch for the v1alpha1 APIs. This flag is deprecated and will be removed in future releases.")
+	isV1Beta1APIEnabled  = flag.Bool("enable-v1beta1-apis", true, "If set, the agents will watch for the v1beta1 APIs.")
 
 	enableTrafficManagerFeature = flag.Bool("enable-traffic-manager-feature", true, "If set, the traffic manager feature will be enabled.")
 
@@ -274,6 +277,11 @@ func setupControllersWithManager(ctx context.Context, hubMgr, memberMgr manager.
 	memberClient := memberMgr.GetClient()
 	hubClient := hubMgr.GetClient()
 
+	if *isV1Alpha1APIEnabled {
+		klog.Error("Fleet v1alpha1 flag is set to true, but this flag is deprecated and will be removed in future releases")
+		return errors.New("v1alpha1 APIs are deprecated and no longer supported, please use v1beta1 APIs instead")
+	}
+
 	if *isV1Beta1APIEnabled {
 		klog.V(1).InfoS("Create internalmembercluster (v1beta1 API) reconciler")
 		if err := (&imcv1beta1.Reconciler{