Skip to content

Conversation

@imalsogreg
Copy link
Collaborator

@imalsogreg imalsogreg commented Dec 3, 2025

  • Parse method calls
  • Lower method calls to HIR
  • Typecheck method calls
  • Rename ProjectRoot to Project and make it the primary input struct for salsa queries
  • Replace several non-salsa queries with salsa ones.

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
promptfiddle Ready Ready Preview Comment Dec 5, 2025 8:21pm

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #2764 will improve performances by ×60

Comparing greg/typecheck-methods (2626404) with canary (70f77c7)

Summary

⚡ 13 improvements
✅ 2 untouched
⏩ 14 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime bench_incremental_add_string_char 4,032.5 µs 72.6 µs ×56
WallTime bench_incremental_add_new_file 29.8 µs 25.5 µs +16.82%
WallTime bench_incremental_no_change 28.9 µs 25 µs +15.81%
WallTime bench_incremental_rename_type 4,106.5 µs 73.8 µs ×56
WallTime bench_empty_project 4,004.1 µs 66.6 µs ×60
WallTime bench_scale_100_functions 4,103.4 µs 72.8 µs ×56
WallTime bench_incremental_modify_function 29.8 µs 25.7 µs +16.12%
WallTime bench_scale_deep_nesting 4,105.2 µs 71.7 µs ×57
WallTime bench_single_simple_file 4,099.5 µs 72.2 µs ×57
WallTime bench_incremental_add_user_field 4,050.5 µs 73.3 µs ×55
WallTime bench_incremental_add_field 29.8 µs 25.9 µs +14.92%
WallTime bench_incremental_add_attribute 4,034.1 µs 73.1 µs ×55
WallTime bench_incremental_close_string 4,034.3 µs 72.2 µs ×56

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants