Standalone orchestration #224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other things: - remove pickle, use basic files for jobid and rank instead - start, stop, continue and restart
- So the first line. Sirocco was not picking up timed out jobs. - Rest is minor
also add accounting remove hardcoded "run"
also fix bug where tasks where removed from a front level while still iterating over it.
also dump/load jobids so that all the information is in state.yaml
Also make computer optional and checked only in the workgraph part
do not exit from auto_submit
essentially start merging with main but manually since icon_task has become a folder, so history is lost
leclairm
requested review from
DropD and
GeigerJ2
and removed request for
DropD
added 12 commits
November 17, 2025 15:00
putting them in the header fails
actaully no need to quote uenv and view
... and some minor changes
GeigerJ2
reviewed
Nov 28, 2025
|
|
||
| # 5 - Link parent and children tasks | ||
| for task in self.tasks: | ||
| task.link_parents_children() |
Collaborator
There was a problem hiding this comment.
in the workgraph branch, we also create the dependencies like this. possibly place to share
GeigerJ2
reviewed
Nov 28, 2025
| def locked(self) -> bool: | ||
| return self.lock_file.exists() | ||
|
|
||
| # =========== Methods to control workflow =========== |
Collaborator
There was a problem hiding this comment.
I'd put all of this into a StandaloneEngine class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.