Skip to content

Commit 3b7fb5c

Browse files
authored
Merge pull request #100 from BadGames-de/fix/1.21.10
[FEAT] Add support to 1.21.3+
2 parents cbca730 + 8c8d4f6 commit 3b7fb5c

File tree

4 files changed

+36
-11
lines changed

4 files changed

+36
-11
lines changed

src/main/java/me/catcoder/sidebar/protocol/PacketIds.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ public enum PacketIds {
2020
map(ProtocolConstants.MINECRAFT_1_20_4, 0x5E),
2121
map(ProtocolConstants.MINECRAFT_1_20_4, 0x5E),
2222
map(ProtocolConstants.MINECRAFT_1_20_6, 0x60),
23-
map(ProtocolConstants.MINECRAFT_1_21_2, 0x67)
23+
map(ProtocolConstants.MINECRAFT_1_21_2, 0x67),
24+
map(ProtocolConstants.MINECRAFT_1_21_5, 0x66)
2425
),
2526
UPDATE_SCORE(
2627
map(ProtocolConstants.MINECRAFT_1_12_2, 0x45),
@@ -34,14 +35,14 @@ public enum PacketIds {
3435
map(ProtocolConstants.MINECRAFT_1_20_2, 0x5D),
3536
map(ProtocolConstants.MINECRAFT_1_20_4, 0x5F),
3637
map(ProtocolConstants.MINECRAFT_1_20_6, 0x61),
37-
map(ProtocolConstants.MINECRAFT_1_21_2, 0x68)
38-
39-
38+
map(ProtocolConstants.MINECRAFT_1_21_2, 0x68),
39+
map(ProtocolConstants.MINECRAFT_1_21_5, 0x67)
4040
),
4141
RESET_SCORE(
4242
map(ProtocolConstants.MINECRAFT_1_20_3, 0x42),
4343
map(ProtocolConstants.MINECRAFT_1_20_4, 0x44),
44-
map(ProtocolConstants.MINECRAFT_1_21_2, 0x49)
44+
map(ProtocolConstants.MINECRAFT_1_21_2, 0x49),
45+
map(ProtocolConstants.MINECRAFT_1_21_5, 0x48)
4546
),
4647
OBJECTIVE_DISPLAY(
4748
map(ProtocolConstants.MINECRAFT_1_12_2, 0x3B),
@@ -55,7 +56,8 @@ public enum PacketIds {
5556
map(ProtocolConstants.MINECRAFT_1_20_2, 0x53),
5657
map(ProtocolConstants.MINECRAFT_1_20_4, 0x55),
5758
map(ProtocolConstants.MINECRAFT_1_20_6, 0x57),
58-
map(ProtocolConstants.MINECRAFT_1_21_2, 0x5C)
59+
map(ProtocolConstants.MINECRAFT_1_21_2, 0x5C),
60+
map(ProtocolConstants.MINECRAFT_1_21_5, 0x5B)
5961

6062
),
6163
OBJECTIVE(
@@ -70,7 +72,8 @@ public enum PacketIds {
7072
map(ProtocolConstants.MINECRAFT_1_20_2, 0x5A),
7173
map(ProtocolConstants.MINECRAFT_1_20_4, 0x5C),
7274
map(ProtocolConstants.MINECRAFT_1_20_6, 0x5E),
73-
map(ProtocolConstants.MINECRAFT_1_21_2, 0x64)
75+
map(ProtocolConstants.MINECRAFT_1_21_2, 0x64),
76+
map(ProtocolConstants.MINECRAFT_1_21_5, 0x63)
7477
);
7578

7679
private final ProtocolConstants.ProtocolMapping[] mappings;

src/main/java/me/catcoder/sidebar/protocol/ProtocolConstants.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,19 @@ public class ProtocolConstants {
5151
public static final int MINECRAFT_1_21 = 767;
5252

5353
public static final int MINECRAFT_1_21_2 = 768;
54+
public static final int MINECRAFT_1_21_3 = 768;
55+
public static final int MINECRAFT_1_21_4 = 769;
56+
public static final int MINECRAFT_1_21_5 = 770;
57+
58+
public static final int MINECRAFT_1_21_6 = 771;
59+
public static final int MINECRAFT_1_21_7 = 772;
60+
public static final int MINECRAFT_1_21_8 = 772;
61+
62+
public static final int MINECRAFT_1_21_9 = 773;
63+
public static final int MINECRAFT_1_21_10 = 773;
5464

5565
public static final int MINIMUM_SUPPORTED_VERSION = MINECRAFT_1_12_2;
56-
public static final int MAXIMUM_SUPPORTED_VERSION = MINECRAFT_1_21_2;
66+
public static final int MAXIMUM_SUPPORTED_VERSION = MINECRAFT_1_21_10;
5767

5868
@Getter
5969
@RequiredArgsConstructor

src/main/java/me/catcoder/sidebar/protocol/ScoreboardPackets.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,13 @@ public <R> ByteBuf createTeamPacket(int mode, int index,
206206

207207
private static void writeDefaults(int serverVersion, @NonNull NetOutput packet) {
208208
packet.writeByte(10); // friendly tags
209-
packet.writeString("always"); // name tag visibility
210-
packet.writeString("always"); // collision rule
209+
if (serverVersion <= ProtocolConstants.MINECRAFT_1_21_4) {
210+
packet.writeString("always"); // name tag visibility
211+
packet.writeString("always"); // collision rule
212+
} else {
213+
packet.writeVarInt(0); // name tag visibility
214+
packet.writeVarInt(0); // collision rule
215+
}
211216
if (serverVersion < ProtocolConstants.MINECRAFT_1_13) {
212217
packet.writeByte(-1); // reset color
213218
} else {

src/main/java/me/catcoder/sidebar/util/version/MinecraftProtocolVersion.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,14 @@ private static NavigableMap<MinecraftVersion, Integer> createLookup() {
6969
map.put(new MinecraftVersion(1, 21, 0), ProtocolConstants.MINECRAFT_1_21);
7070
map.put(new MinecraftVersion(1, 21, 1), ProtocolConstants.MINECRAFT_1_21);
7171
map.put(new MinecraftVersion(1, 21, 2), ProtocolConstants.MINECRAFT_1_21_2);
72-
72+
map.put(new MinecraftVersion(1, 21, 3), ProtocolConstants.MINECRAFT_1_21_3);
73+
map.put(new MinecraftVersion(1, 21, 4), ProtocolConstants.MINECRAFT_1_21_4);
74+
map.put(new MinecraftVersion(1, 21, 5), ProtocolConstants.MINECRAFT_1_21_5);
75+
map.put(new MinecraftVersion(1, 21, 6), ProtocolConstants.MINECRAFT_1_21_6);
76+
map.put(new MinecraftVersion(1, 21, 7), ProtocolConstants.MINECRAFT_1_21_7);
77+
map.put(new MinecraftVersion(1, 21, 8), ProtocolConstants.MINECRAFT_1_21_8);
78+
map.put(new MinecraftVersion(1, 21, 9), ProtocolConstants.MINECRAFT_1_21_9);
79+
map.put(new MinecraftVersion(1, 21, 10), ProtocolConstants.MINECRAFT_1_21_10);
7380

7481
return map;
7582
}

0 commit comments

Comments
 (0)