Skip to content

Conversation

@Nate-Wessel
Copy link
Contributor

What this pull request accomplishes:

  • applies leg-specific anomalous_ranges to exit legs too (formerly only applied to entry leg)

Issue(s) this solves:

What, in particular, needs to reviewed:

  • logical correctness
  • that moving the conditions from a JOIN to the WHERE clause doesn't slow things down at scale (I tried it filtered down to the small example from the issue and it didn't take any longer)

What needs to be done by a sysadmin after this PR is merged

  • replace the view

Also move anomalous range filter into WHERE clause
@Nate-Wessel Nate-Wessel self-assigned this Sep 3, 2025
Copy link
Collaborator

@gabrielwol gabrielwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe you raise a good point about exit volumes not being handled correctly, but I think it applies only to the volumes_15min_atr_filtered view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miovision volumes_15min_* views do not properly filter leg-specific anomalies

3 participants