Revert "crypto/virtio: fix cookies leak"

bluca · bluca · commit 04536b2361c4 · 2025-12-11T10:56:57.000Z
This commit causes a virtio regression: EAL: Error: Invalid memory Bugzilla ID: 1849 This reverts commit 8b0d855.
diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -266,7 +266,6 @@ void
 virtio_crypto_queue_release(struct virtqueue *vq)
 {
 	struct virtio_crypto_hw *hw;
-	uint16_t i;
 
 	PMD_INIT_FUNC_TRACE();
 
@@ -277,9 +276,6 @@ virtio_crypto_queue_release(struct virtqueue *vq)
 
 		rte_memzone_free(vq->mz);
 		rte_mempool_free(vq->mpool);
-		for (i = 0; i < vq->vq_nentries; i++)
-			rte_free(vq->vq_descx[i].cookie);
-
 		rte_free(vq);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,6 @@ void`
`266`	`266`	`virtio_crypto_queue_release(struct virtqueue *vq)`
`267`	`267`	`{`
`268`	`268`	`struct virtio_crypto_hw *hw;`
`269`		`- uint16_t i;`
`270`	`269`
`271`	`270`	`PMD_INIT_FUNC_TRACE();`
`272`	`271`
`@@ -277,9 +276,6 @@ virtio_crypto_queue_release(struct virtqueue *vq)`
`277`	`276`
`278`	`277`	`rte_memzone_free(vq->mz);`
`279`	`278`	`rte_mempool_free(vq->mpool);`
`280`		`- for (i = 0; i < vq->vq_nentries; i++)`
`281`		`- rte_free(vq->vq_descx[i].cookie);`
`282`		`-`
`283`	`279`	`rte_free(vq);`
`284`	`280`	`}`
`285`	`281`	`}`