Skip to content

Commit babc45d

Browse files
committed
Review comments
1 parent b0030e8 commit babc45d

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

cmd/system-probe/config/adjust_npm.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,8 @@ func adjustNetwork(cfg config.Config) {
110110
if ebpflessEnabled {
111111
const notSupportedEbpfless = "not supported when ebpf-less is enabled"
112112
disableConfigs = append(disableConfigs, []struct{ key, reason string }{
113-
{spNS("enable_conntrack_all_namespaces"), notSupportedEbpfless},
114113
{netNS("enable_protocol_classification"), notSupportedEbpfless},
115-
{evNS("network_process", "enabled"), notSupportedEbpfless},
116-
{netNS("enable_root_netns"), notSupportedEbpfless}}...,
114+
{evNS("network_process", "enabled"), notSupportedEbpfless}}...,
117115
)
118116
}
119117

pkg/network/filter/packet_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// This product includes software developed at Datadog (https://www.datadoghq.com/).
44
// Copyright 2024-present Datadog, Inc.
55

6-
//nolint:revive // TODO(NET) Fix revive linter
6+
// Package filter exposes interfaces and implementations for packet capture
77
package filter
88

99
import (

pkg/network/filter/packet_source_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
//go:build linux
77

8-
//nolint:revive // TODO(NET) Fix revive linter
8+
// Package filter exposes interfaces and implementations for packet capture
99
package filter
1010

1111
import (

pkg/network/filter/socket_filter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
//go:build linux_bpf
77

8+
// Package filter exposes interfaces and implementations for packet capture
89
package filter
910

1011
import (
1112
"encoding/binary"
1213
"runtime"
1314

14-
"golang.org/x/sys/unix"
15-
1615
manager "github.com/DataDog/ebpf-manager"
16+
"golang.org/x/sys/unix"
1717

1818
"github.com/DataDog/datadog-agent/pkg/network/config"
1919
"github.com/DataDog/datadog-agent/pkg/util/kernel"

pkg/network/usm/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
// MinimumKernelVersion indicates the minimum kernel version required for HTTP monitoring
2323
var MinimumKernelVersion kernel.Version
2424

25-
// ErrNotSupported is the error returned USM is not supported on this platform
25+
// ErrNotSupported is the error returned if USM is not supported on this platform
2626
var ErrNotSupported = errors.New("Universal Service Monitoring (USM) is not supported")
2727

2828
func init() {

0 commit comments

Comments
 (0)