Skip to content

Pass down remote config id to kafka actions #43356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 2 commits into from
Nov 21, 2025
Merged

Pass down remote config id to kafka actions #43356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a74483
pass down remote config id to kafka_actions
piochelepiotr Nov 21, 2025
ee529fd
add release note
piochelepiotr Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions comp/core/autodiscovery/providers/datastreams/kafka_actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ func (c *actionsController) update(updates map[string]state.RawConfig, applyStat
}

actionsMap["run_once"] = true
actionsMap["remote_config_id"] = parsed.remoteConfigID
for k, v := range auth {
actionsMap[k] = v
}
Expand Down Expand Up @@ -182,6 +183,7 @@ type parsedActionsConfig struct {
path string
bootstrapServers string
actionsJSON json.RawMessage
remoteConfigID string
}

func parseActionsConfig(updates map[string]state.RawConfig, applyStateCallback func(string, state.ApplyStatus)) []parsedActionsConfig {
Expand All @@ -205,6 +207,7 @@ func parseActionsConfig(updates map[string]state.RawConfig, applyStateCallback f
path: path,
bootstrapServers: bootstrapServers,
actionsJSON: cfg.Actions,
remoteConfigID: rawConfig.Metadata.ID,
})
}
return configs
Expand Down
9 changes: 6 additions & 3 deletions comp/core/autodiscovery/providers/datastreams/kafka_actions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestActionsController(t *testing.T) {

rcUpdate := map[string]state.RawConfig{
"config_1": {Config: []byte("invalid")},
"config_2": {Config: serializedConfig},
"config_2": {Config: serializedConfig, Metadata: state.Metadata{ID: "test_remote_config_id"}},
}

updateStatus := make(map[string]state.ApplyStatus)
Expand Down Expand Up @@ -133,6 +133,9 @@ func TestActionsController(t *testing.T) {
// Check that run_once was injected
assert.Equal(t, true, instance["run_once"])

// Check that remote_config_id was injected
assert.Equal(t, "test_remote_config_id", instance["remote_config_id"])

// Check that actions are present
assert.NotNil(t, instance["read_messages"])
}
Expand Down Expand Up @@ -167,7 +170,7 @@ func TestActionsControllerNoBootstrapServers(t *testing.T) {
require.NoError(t, err)

rcUpdate := map[string]state.RawConfig{
"config_1": {Config: serializedConfig},
"config_1": {Config: serializedConfig, Metadata: state.Metadata{ID: "no_bootstrap_test_id"}},
}

updateStatus := make(map[string]state.ApplyStatus)
Expand Down Expand Up @@ -204,7 +207,7 @@ func TestActionsControllerNoMatchingKafkaConsumer(t *testing.T) {
require.NoError(t, err)

rcUpdate := map[string]state.RawConfig{
"config_1": {Config: serializedConfig},
"config_1": {Config: serializedConfig, Metadata: state.Metadata{ID: "no_match_test_id"}},
}

updateStatus := make(map[string]state.ApplyStatus)
Expand Down
2 changes: 2 additions & 0 deletions releasenotes/notes/kafka-actions-tagging-848281611b7fd5bb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
enhancements:
- Add remote config ID tagging to events generated by kafka_action integration for easy UI filtering