Skip to content

ScriptExecutor does not respect variabledEnabled for VerifySchema() #5

@AaronShiels

Description

@AaronShiels

Despite having the setting at it's immediate disposal in a private field, the ScriptExecutor ignores this value when verifying schema through the AdHocSqlRunner.
var sqlRunner = new AdHocSqlRunner(dbCommandFactory, sqlObjectParser, Schema, () => true);
https://github.com/DbUp/DbUp/blob/master/src/dbup-core/Support/ScriptExecutor.cs#L78

This is problematic for those extending the PostgresqlScriptExecutor and overriding GetVerifySchemaSql(string schema); to perform additional actions, such as assigning privileges to the schema and creating related roles if non-existent, as dbup-postgresql is particularly sensitive to variable issues as per #1 .

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Bugs

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions