Skip to content
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# @DecisiveAI/reviewers will be the default owners for
# everything in the repo. Unless a later match takes
# precedence, reviewers team will be requested for review
# when someone opens a pull request.
* @DecisiveAI/reviewers
69 changes: 69 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
<!--
For Work In Progress pull requests, please use the Draft PR feature.
For a timely review/response, please avoid force-pushing additional
commits if your PR already received reviews or comments.
Before submitting a pull request, please ensure you've done the following:
- Create small PRs. In most cases this will be possible.
- Provide tests for your changes.
- Fill out the pull request template.
- Ensure your PR title follow the guideline described in:
https://github.com/DecisiveAI/changelogs?tab=readme-ov-file#pull-request-title
-->

## Description
<!--
Please describe the changes you made in this pull request.
If applicable, please feel free to include screenshots to make it
easier for reviewers understand your pull request.
If there are any relevant documentations that help explain your pull
request, please feel free to include them as well.
-->

- ENG-<!--REPLACE THIS WITH JIRA TICKET NUMBER-->

## What type of PR is this? (only check one)
<!--
If you need to check more than one (except if the other type is `doc`,
always do add more doc) to properly capture the PR type, please
consider splitting up your PR.
If you selected Other, please ensure the type you provided
is one of the valid types outlined in
https://github.com/DecisiveAI/changelogs?tab=readme-ov-file#type
-->

- [ ] Feature (`feat`)
- [ ] Bug Fix (`fix`)
- [ ] Refactor (`refactor`)
- [ ] Documentation Update (`doc`)
- [ ] Other, please specify:

### Does this PR introduce any breaking changes?
- [ ] No
- [ ] Yes, and this is why:
- [ ] I need help determining if there are any breaking changes

### Does the PR title type prefix match the selected type?
- [ ] Yes
- [ ] No, and this is why:
- [ ] I need help select the right one

## Added/updated tests?
_Please keep the code coverage percentage at 80% and above._
- [ ] Yes
- [ ] No, and this is why:
- [ ] I need help with writing tests

## Added/updated documentation and/or lab?
<!--
If it does not make sense for the changes done in this repository to ever
need to update lab repo, then feel free to change the wording of this
section when copied over.
-->
- [ ] Yes <!--If applicable, provide lab PR url here-->
- [ ] N/A
- [ ] I need help
89 changes: 87 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,87 @@
# changelogs
Changelogs for MyDecisive components
# Changelogs

This repository contains guidelines, templates, configurations, etc for MDAI that will help us format everything properly so that our changelog generator will function as expected. In addition to that, this repository will also contain the changelog that outlines changes across different MDAI components that makes up an release.

### Table of Contents
- [Guidelines](#guidelines)
- [Pull Request Format](#pull-request-format)
- [Pull Request Title](#pull-request-title)
- [Type](#type)
- [[Optional] Scope](#optional-scope)
- [Breaking Changes Indicator](#breaking-changes-indicator)
- [Subject](#subject)
- [Example](#examples)
- [Pull Request Description](#pull-request-description)

# Guidelines

## Pull Request Format

Changes can only be `Squashed & Merged` to `main` of any repositories of MDAI via a pull request. The pull request must follow the format outlined in this section to both give reviewer an easier time to understand context of the pull request and also to ensure our changelog generator can parse the changes properly.

### Pull Request Title

Title of a pull request must follow the [conventional commit](https://www.conventionalcommits.org/en/v1.0.0/) format (without optional body and footer), meaning the title must following the following structure:

<pre>
<a href="#type">&lt;type&gt;</a></font>(<a href="#optional-scope">&lt;optional scope&gt;</a>): <a href="#subject">&lt;subject&gt;</a>
</pre>

#### Type

Must be one of the following:

- `feat`: Add or change a feature
- `fix`: Fixes issue with the codebase (e.g., bug, business logic error, typo, etc)
- `security`: A type of fixes that resolve security concerns
- `style`: A type of fixes address code style (e.g., white-space, formatting, missing semi-colons, etc) and do not affect application behavior
- `doc`: Documentation only changes
- `refactor`: Rewrite or restructure code without altering behavior
- `perf`: A type of refactor that specifically improves performance
- `test`: Adding missing tests or correcting existing tests
- `revert`: Reverts a previous commit
- *Note: For revert type, `<subject>` must be the commit message of the commit its reverting (e.g., `revert: fix: fix container/service builder`).*
- `build`: Affect build-related components (e.g., build tools, dependencies, project version, CI/CD pipelines, etc)
- `chore`: Miscellaneous commits (e.g., modifying `.gitignore`)

#### [Optional] Scope

The scope is optional and provides additional contextual information.

> [!IMPORTANT]
> Do NOT use issue identifiers as scopes.

TODO: Additional instructions will be added once we figure out how we'll be combining changelogs across multiple repositories to form MDAI changelog.

#### Breaking Changes Indicator

A commit that introduce breaking changes must be indicated by an `!` before the `:` in the subject line (e.g. `feat(scope)!: remove deprecated`).

#### Subject

The subject contains a succinct description of the change:
- Use the imperative, present tense: "change" not "changed" nor "changes"
- Do not capitalize the first letter
- Do not end the description with a period (.)
- In case of breaking changes, see [Breaking Changes Indicator](#breaking-changes-indicator)

#### Examples

```
fix: fix container/service builder
```
```
feat(mdai-event-hub): add generic webhook action support
```
```
refactor!: update labels for managed ConfigMaps
```

### Pull Request Description

Make sure you followed the instruction outlined in the `PULL_REQUEST_TEMPLATE.md` of the repository you are working in.

If the repository you are working in does not have a pull request template yet, please copy [`PULL_REQUEST_TEMPLATE.md`](.github/PULL_REQUEST_TEMPLATE.md) and paste it in the `.github` folder.

> [!TIP]
> `PULL_REQUEST_TEMPLATE.md` find in this repository is only meant to be used as a baseline, it can and should be modified to fit the specific need of each repositories.