Skip to content

MapSubsetEvent shouldn't always be filtered as duplicate #1239

@shmuelzon

Description

@shmuelzon

Checks

  • I have read the above text and I'm aware of the situation
  • I have searched the existing issues and no issue is describing my issue
  • I'm not creating an issue to add support for a new device/model.
  • I have installed the latest version

The problem

When changing the active map, in some cases (detailed below), not all map subset elements, e.g., virtual walls will appear.

An excerpt, taken from #1233:
As for the issue of virtual walls not appearing after selecting a different map, let me know if you want to handle it here or if I should open a separate bug/PR. The gist of it is this:

  • I have only a single virtual wall in my map
    • My robot doesn't have any other MapSetTypes as the rooms are handled differently and I don't have any no-mop zones
  • When starting my test script, everything's enumerated and displayed correctly in the map
  • I then switch to my other (mostly empty, test) map which doesn't have any virtual walls
    • This clears the existing virtual wall entry subset as get subsets returned an empty list
  • I then switch back to the main map that, in turn, get's all the map set information
  • The single virtual wall I have is also received and an event is to be published on it
    • The event is filtered out since it's the same event that was sent when the original map was loaded
    • This means that the new map is drawn without the virtual wall

If I had a virtual wall in my second map, then everything would be fine since the event would be different each time and not filtered. Likewise, if I had a second virtual wall in my map, it would also work since each event would be be different when sending the first subset, then the second, (map change) then the first again.

On which deebot device (vacuum) you have the issue?

Deebot X9

Which version of the deebot-client are you using?

15.1.0

Country

CN

Continent

None

Anything in the logs that might be useful for us?

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions