chore: add featureId as property on BaseVariable

Author: kaushalkapasi

src/main/java/com/devcycle/sdk/server/common/model/BaseVariable.java

@@ -31,4 +31,8 @@ public class BaseVariable {
 
     @Schema(description = "Evaluation reason")
     private EvalReason eval;
+
+    @Schema(description = "Feature ID")
+    @JsonProperty("_feature")
+    private String featureId;
 }

src/main/java/com/devcycle/sdk/server/common/model/EvalReason.java

@@ -40,9 +40,7 @@ private EvalReason(String reason, String details) {
     }
 
     public static EvalReason defaultReason(DefaultReasonDetailsEnum details) {
-        String defaultDetails = details.getValue();
-        System.out.println("Setting default reason to " + defaultDetails);
-        return new EvalReason("DEFAULT", defaultDetails);
+        return new EvalReason("DEFAULT", details.getValue());
     }
 
     public String getReason() {

src/test/java/com/devcycle/sdk/server/cloud/DevCycleCloudClientTest.java

@@ -161,7 +161,7 @@ public void getVariableValueByKeyTest() {
     }
 
     @Test
-    public void getVariablesTest() throws DevCycleException {
+    public void allVariablesTest() throws DevCycleException {
         DevCycleUser user = DevCycleUser.builder()
                 .userId("j_test")
                 .build();
@@ -177,6 +177,7 @@ public void getVariablesTest() throws DevCycleException {
         BaseVariable testNumber = variables.get("test-number");
         Assert.assertNotNull(testNumber);
         Assert.assertEquals(100, (int) testNumber.getValue());
+        Assert.assertEquals("62fbf6566f1ba302829f9e32", testNumber.getFeatureId());
         Assert.assertEquals(Variable.TypeEnum.NUMBER, testNumber.getType());
         Assert.assertEquals("SPLIT", testNumber.getEval().getReason());
         Assert.assertEquals("Random Distribution | User Id", testNumber.getEval().getDetails());

src/test/java/com/devcycle/sdk/server/helpers/TestResponse.java

@@ -58,27 +58,31 @@ public static Call<Map<String, BaseVariable>> getVariables() {
                 .value(false)
                 .type(Variable.TypeEnum.BOOLEAN)
                 .eval(new EvalReason("SPLIT", "Random Distribution | User Id", "test_cloud_target_id"))
+                .featureId("62fbf6566f1ba302829f9e32")
                 .build());
         variables.put("test-true", BaseVariable.builder()
                 .id(UUID.randomUUID().toString())
                 .key("test-true")
                 .value(true)
                 .type(Variable.TypeEnum.BOOLEAN)
                 .eval(new EvalReason("SPLIT", "Random Distribution | User Id", "test_cloud_target_id"))
+                .featureId("62fbf6566f1ba302829f9e32")
                 .build());
         variables.put("test-number", BaseVariable.builder()
                 .id(UUID.randomUUID().toString())
                 .key("test-number")
                 .value(100)
                 .type(Variable.TypeEnum.NUMBER)
                 .eval(new EvalReason("SPLIT", "Random Distribution | User Id", "test_cloud_target_id"))
+                .featureId("62fbf6566f1ba302829f9e32")
                 .build());
         variables.put("test-json", BaseVariable.builder()
                 .id(UUID.randomUUID().toString())
                 .key("test-json")
                 .value("{'some':'json''}")
                 .type(Variable.TypeEnum.JSON)
                 .eval(new EvalReason("SPLIT", "Random Distribution | User Id", "test_cloud_target_id"))
+                .featureId("62fbf6566f1ba302829f9e32")
                 .build());
 
         return Calls.response(variables);

src/test/java/com/devcycle/sdk/server/local/DevCycleLocalClientTest.java

@@ -377,6 +377,11 @@ public void allVariablesTest() {
         Assert.assertEquals(variables.get("num-var").getId(), "65272363125123fca69d3a7d");
         Assert.assertEquals(variables.get("json-var").getId(), "64372363125123fca69d3f7b");
         Assert.assertEquals(variables.size(), 4);
+
+        Assert.assertEquals(variables.get("string-var").getFeatureId(), "62fbf6566f1ba302829f9e32");
+        Assert.assertEquals(variables.get("a-cool-new-feature").getFeatureId(), "62fbf6566f1ba302829f9e32");
+        Assert.assertEquals(variables.get("num-var").getFeatureId(), "62fbf6566f1ba302829f9e32");
+        Assert.assertEquals(variables.get("json-var").getFeatureId(), "62fbf6566f1ba302829f9e32");
     }
 
     @Test