Skip to content

Commit fce30ae

Browse files
committed
chore: add _feature to Variable protos for encoding/decoding from WASM Bucketing
1 parent 13aa4f7 commit fce30ae

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/run-test-harness.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ jobs:
1717
sdks-to-test: java
1818
sdk-github-sha: ${{github.event.pull_request.head.sha}}
1919
github-token: ${{ secrets.TEST_HARNESS_GH_SECRET }}
20-
sdk-capabilities: '["cloud", "edgeDB", "clientCustomData", "v2Config", "allFeatures", "allVariables", "evalReason", "eventsEvalReason", "cloudEvalReason"]'
20+
sdk-capabilities: '["cloud", "edgeDB", "clientCustomData", "v2Config", "allFeatures", "allVariables", "varableFeatureIds", "evalReason", "eventsEvalReason", "cloudEvalReason"]'

src/main/java/com/devcycle/sdk/server/cloud/api/DevCycleCloudClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public <T> Variable<T> variable(DevCycleUser user, String key, T defaultValue) {
143143
Call<Variable> response = api.getVariableByKey(user, key, dvcOptions.getEnableEdgeDB());
144144
variable = getResponseWithRetries(response, 5);
145145
if (variable.getType() != variableType) {
146-
throw new IllegalArgumentException(ErrorResponse.ErrorMessage.VARIABLE_TYPE_MISMATCH.getMessage());
146+
throw new IllegalArgumentException("Variable type mismatch, returning default value");
147147
}
148148
if (beforeError != null) {
149149
throw beforeError;
@@ -161,7 +161,7 @@ public <T> Variable<T> variable(DevCycleUser user, String key, T defaultValue) {
161161
.isDefaulted(true)
162162
.build();
163163

164-
if (exception.getMessage().equals(ErrorResponse.ErrorMessage.VARIABLE_TYPE_MISMATCH.getMessage())) {
164+
if (exception.getMessage().equals("Variable type mismatch, returning default value")) {
165165
variable.setEval(EvalReason.defaultReason(EvalReason.DefaultReasonDetailsEnum.VARIABLE_TYPE_MISMATCH));
166166
} else {
167167
variable.setEval(EvalReason.defaultReason(EvalReason.DefaultReasonDetailsEnum.ERROR));

src/main/proto/variableForUserParams.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ message SDKVariable_PB {
7070
double doubleValue = 5;
7171
string stringValue = 6;
7272
NullableString evalReason = 7;
73+
NullableString _feature = 8;
7374
EvalReason_PB eval = 9;
7475
}
7576

0 commit comments

Comments
 (0)