Fix(gui): Correct autostart detection in dev environment #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_query_autostart` method failed to detect the autostart status on Windows when running in a development (non-packaged) environment. The check was looking for a quoted application path in the registry, but in development, the entry is an unquoted script path passed as an argument to the Python interpreter. This commit modifies the check to use the unquoted path when the application is not packaged, ensuring correct detection. A new unit test is included to validate this fix.
Owner
|
Hello, Not sure how you were testing that, but this is what I get from the current master branch: 
I'm pretty sure that's correct already. Moreover, a check like this would have to modify
|
Owner
|
Well, since my findings point at there not being an error after all, and a lack of further input, I guess this one can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_query_autostartmethod failed to detect the autostart status on Windows when running in a development (non-packaged) environment.The check was looking for a quoted application path in the registry, but in development, the entry is an unquoted script path passed as an argument to the Python interpreter.
This commit modifies the check to use the unquoted path when the application is not packaged, ensuring correct detection. A new unit test is included to validate this fix.