-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: Move numtracker into the BlueskyContext #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
+ Coverage 94.59% 94.60% +0.01%
==========================================
Files 41 41
Lines 2588 2578 -10
==========================================
- Hits 2448 2439 -9
+ Misses 140 139 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4dc48f7 to
1448616
Compare
de1321b to
fc97560
Compare
|
@tpoliaw while I like the reduction in shenanigans I was already worried about how much of a god object |
|
I don't know how much of a god object it is. As far as I can see it's a bucket holding all the bluesky state. If the device loading is moved into dodal, everything else makes sense to be left, doesn't it? If anything it's cleaner than using a module full of globals as a state object. |
callumforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, definitely an improvement
dc4b085 to
3c2c9eb
Compare
This reverts commit c5c7b46.
3c2c9eb to
cc8896a
Compare
Moving the numtracker into the bluesky context means we don't need to do the 'create context -> create numtracker -> configure context -> check path provider` shenanigans in the top level setup function and the path provider can be available to pass to device factories if we move to a dodal-less approach to devices.