Skip to content

Commit 0beff74

Browse files
committed
Tweak lint job
1 parent 52dfebc commit 0beff74

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,12 @@ jobs:
1515
uses: actions/checkout@v4
1616
- name: Set up Node.js
1717
uses: actions/setup-node@v4
18-
with:
19-
node-version: '18.18.0' # Minimum version for eslint: https://eslint.org/docs/latest/use/getting-started
2018
- name: Run Lint
21-
# "--production" to skip installing devDependencies modules
19+
with:
20+
node-version: 'lts/*'
2221
run: |
2322
npm ci --production || exit 1
24-
toplevel=$(git rev-parse --show-toplevel)
25-
if ! make -C "$toplevel" lint; then
26-
echo "Linting errors"
27-
exit 1
28-
fi
23+
make lint
2924
3025
test:
3126
runs-on: ubuntu-22.04
@@ -106,4 +101,4 @@ jobs:
106101
toplevel=$(git rev-parse --show-toplevel)
107102
echo "Found $("$BROWSER" --version)"
108103
testdir=${toplevel}/tests/selenium
109-
xvfb-run --auto-servernum pytest --capture=no --color=yes --verbose --durations=10 "$testdir"
104+
xvfb-run --auto-servernum pytest --capture=no --color=yes --verbose --durations=10 "$testdir"

0 commit comments

Comments
 (0)