Skip to content

Commit befa635

Browse files
committed
Add Edge Beta tests
1 parent f3f225a commit befa635

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

.github/workflows/test.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-22.04
1414
strategy:
1515
matrix:
16-
job: [lint, firefox, firefox-beta, firefox-nightly, firefox-esr]
16+
job: [lint, firefox, firefox-beta, firefox-nightly, firefox-esr, edge-beta]
1717
# job: [lint, firefox, edge-beta]
1818
include:
1919
- job: lint
@@ -36,9 +36,9 @@ jobs:
3636
INFO: "Firefox ESR"
3737
BROWSER: "firefox"
3838
FIREFOX_VERSION: "latest-esr"
39-
# - job: edge-beta
40-
# INFO: "Edge Beta"
41-
# BROWSER: "microsoft-edge-beta"
39+
- job: edge-beta
40+
INFO: "Edge Beta"
41+
BROWSER: "microsoft-edge-beta"
4242
env:
4343
INFO: ${{ matrix.INFO }}
4444
BROWSER: ${{ matrix.BROWSER }}
@@ -67,6 +67,14 @@ jobs:
6767
if: ${{ matrix.BROWSER == 'firefox' }}
6868
uses: browser-actions/setup-geckodriver@latest
6969

70+
- name: Set up Edge
71+
if: ${{ matrix.BROWSER == 'microsoft-edge-beta' }}
72+
uses: browser-actions/setup-edge@v1
73+
with:
74+
edge-version: beta
75+
# Why do we test with Edge Beta but not Edge?
76+
77+
# - run: Xvfb :99 &
7078
# - name: Install Browser Dependencies # Firefox documentation
7179
# run: |
7280
# sudo apt update

scripts/setup_travis.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ case $INFO in
8484
;;
8585
*Firefox*)
8686
check_browser
87+
# sudo apt-get install -y xvfb
8788
# install_geckodriver
8889
install_python_deps
8990
;;

tests/selenium/pbtest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ def firefox_manager(self):
231231
# disable JSON viewer as it breaks parsing JSON pages
232232
opts.set_preference("devtools.jsonview.enabled", False)
233233

234-
# opts.add_argument("--headless")
234+
opts.add_argument("--headless")
235235

236236
# to produce a trace-level geckodriver.log,
237237
# remove the log_output argument to FirefoxService()

0 commit comments

Comments
 (0)