-
Notifications
You must be signed in to change notification settings - Fork 242
possible gui installer framework #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
command was: sh <(curl https://create.tauri.app/sh) the chosen options were: Project name · installer-gui Identifier · com.rayhunter-installer.app Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, deno, bun) Choose your package manager · npm Choose your UI template · Svelte - (https://svelte.dev/) Choose your UI flavor · TypeScript
we need to track package-lock.json to keep the tauri JS packages in sync with tauri's rust packages in cargo.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with it and it seems fine, but i think this is going to be a maintenance liability. Building takes a very long time and the amount of storage needed is very large. There are a lot of dependencies. Most Android applications that I have seen build faster.
Currently the GUI wraps the CLI, and while there are talks to integrate the two further, I actually think I prefer it if they stay separate, like now.
I'm approving it because it's separate and because having a GUI is important for UX. I'd suggest to add a few pre-fillable "suggested" commands to the UI.
Aside, building it as an android app seems to work (tauri android init && tauri android build), but the resulting APK seems to be corrupted:
$ adb install /home/markus/projects/rayhunter/installer-gui/src-tauri/gen/android/app/build/outputs/apk/universal/release/app-universal-release-unsigned.apk
Performing Streamed Install
adb: failed to install /home/markus/projects/rayhunter/installer-gui/src-tauri/gen/android/app/build/outputs/apk/universal/release/app-universal-release-unsigned.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl378380804.tmp/base.apk: Attempt to get length of null array]
this PR is pretty massive, but i think does close to the bare minimum to set up a working, proof of concept rayhunter GUI installer with CI. i tried to keep the commit history clean with useful commit messages so i suspect reviewing it commit by commit is the easiest way to go. with that said, if whoever reviews this would like me to break this up or structure it in a different way, please don't hesitate to ask
i'd personally like to get this merged into main or if necessary a separate branch on this repo to allow us to iterate on this in smaller chunks and allow others to work on it, but i'm open to other ideas
the big things that still need to be done here before this is ready for real users imo are:
if you want to play with prebuilt assets based on bmw@b482c72 (technically bmw@41ad17c which makes tiny, throwaway CI changes to the previous commit), you can find the files at https://github.com/bmw/rayhunter/releases/tag/v1761870661. if you do this, please keep in mind:
... --admin-password $m@rt$p0tc0nf!gand not... --admin-password '$m@rt$p0tc0nf!g'as the latter would include the single quotes in the password argument