Add rule to warn\error on use of Schema.Number and Schema.Date

[adrian-gierakowski]

What is the problem this feature would solve?

and suggest use of Schema.JsonNumber and Schema.ValidDate

see: https://discord.com/channels/795981131316985866/847382157861060618/1442620373714735196

What is the feature you are proposing to solve the problem?

Schema.Number and Schema.Date are almost never the right schema to use as they allow values which most of the time would be considered invalid and which do not serialise in expected way

What alternatives have you considered?

No response

[adrian-gierakowski]

I asked Google Jules to implement this. @mattiamanzati would you mind having a quick look here and let me know if what it did makes sense at all? Thanks!

[mattiamanzati]

I've left some comments on the PR, thanks a lot!

[adrian-gierakowski]

I've left some comments on the PR, thanks a lot!

Thank you. I've repeated your comments on the PR since it looks like the agent only responds to my comments. Let's see what it cooks.

Btw. do the tests it added look sane? I haven't had time to look into the codebase yet so not sure if they are actually doing anything. I'll clone the repo and validate what it did tomorrow (and do final fixed if necessary).

[mattiamanzati]

They test something, probably not a real world scenario I would prefer to have as well.
I left some other comments right now

[adrian-gierakowski]

@mattiamanzati I've massaged the PR a bit submitted here. I've tested it locally and it seems to do as intended