🧪 EPIC: Test Suite Stabilization - Fix Failing Tests for MVP

[Eibon7]

🧪 Test Suite Stabilization Epic

Last Updated: 2025-10-23
Status: 🔴 CRITICAL - Main branch has 55% test failure rate
Approach: Option C (Hybrid) - Baseline protection + Bug smashing sprint

---

⚠️ Situación Actual vs Estimación Original

Datos Originales (desactualizados)

Total test files: 321
Failing test files: ~30 (9% failure rate)

Datos Reales (2025-10-23)

Total test suites: 323
Failing test suites: 179 (55% failure rate) 🔴 CRÍTICO
Passing test suites: 144 (45%)
Gap desde estimación: +149 suites failing

La situación es MUCHO peor de lo estimado originalmente.

---

🎯 Objetivos Actualizados

Objetivo Principal

Reducir test failures de 179 suites → <10 suites (<3% failure rate)

Bloqueadores Identificados

1. Main branch rota: 179 failing suites establecen baseline imposible
2. Completion validation bloqueada: Requiere 100% passing (imposible actualmente)
3. Sin baseline tracking: No hay mecanismo para prevenir regresiones
4. Environment issues: DATABASE_URL, API keys, configuración de mocks

---

📊 Core Flows vs Complementary Flows

Esta epic cubre TODOS los flujos, distinguiendo entre:

Core Flows 🔴 (Flujos principales del producto)

Viajes de usuario críticos que definen el valor del producto.

Complementary Flows 🟡 (Funcionalidad de soporte)

Validación, seguridad, y características complementarias.

---

📋 Sub-Issues (Core Flows)

P0 - Core Product Flows

• [Test Fix] Ingestor Test Suite - Acknowledgment, Error Handling, Order Processing #481 - Fix Ingestor Test Suite (P0 Core) core-flow

  • 3 failing test suites
  • Sistema de ingesta de comentarios

• [Test Fix] Shield Test Suite - Stability, UI Integration, Escalation Logic #482 - Fix Shield Test Suite (P0 Core) core-flow

  • 4+ failing test suites
  • Related: Pre-existing Shield test failures blocking PRs #633 (6 suites temporalmente skipped)
  • Sistema de moderación automática

• [Test Fix] Roast Generation Test Suite - Core Flow, Validation, Enhanced Features #483 - Fix Roast Generation Tests (P0 Core) core-flow

  • 5 failing test suites
  • Feature principal del producto

• [Test Fix] Multi-Tenant & Billing Test Suite - RLS, Tier Limits, Stripe Webhooks #484 - Fix Multi-Tenant & Billing Tests (P0 Core) core-flow

  • 6+ failing test suites (incluye database security)
  • Seguridad multi-tenant + billing

• Fix OAuth Integration Test Suite (P0 - CORE FLOW) #638 - Fix OAuth Integration Test Suite (P0 Core) core-flow

  • ~20 failing tests
  • Onboarding principal (conexión con plataformas)

---

📋 Sub-Issues (Complementary Flows)

P0 - Security & Infrastructure

• Fix Database Security Test Suite (P0 - SECURITY) #639 - Fix Database Security Test Suite (P0 Security) complementary-flow
  • ~15 failing test suites
  • RLS policies, multi-tenant isolation

P1 - API & Business Logic

• Fix Integration Routes Test Suite (P1 - COMPLEMENTARY FLOW) #641 - Fix Integration Routes Test Suite (P1) complementary-flow

  • ~12 failing test suites
  • API endpoints de gestión de plataformas

• Fix Tier Validation Service Tests (P1 - COMPLEMENTARY FLOW) #642 - Fix Tier Validation Service Tests (P1) complementary-flow

  • ~8 failing test suites
  • Límites por plan, billing logic

• Fix Frontend/UI Test Suite (P1 - COMPLEMENTARY FLOW) #643 - Fix Frontend/UI Test Suite (P1) complementary-flow

  • ~10 failing test suites (estimado, requiere audit)
  • Component tests, E2E flows

• Fix Worker Test Suite (P1 - COMPLEMENTARY FLOW) #644 - Fix Worker Test Suite (P1) complementary-flow

  • ~12 failing test suites (estimado, requiere audit)
  • Background job processing

• [Test Fix] Unit Test Suite - Routes, Middleware, Services (15 files) #485 - Fix Unit Test Suite (P1) complementary-flow

  • ~15 failing test suites
  • Routes, middleware, services

P2 - Developer Tools & Long Tail

• Fix CLI Test Suite (P2 - COMPLEMENTARY FLOW) #645 - Fix CLI Test Suite (P2) complementary-flow

  • ~8 failing test suites
  • Developer tooling

• Audit and Fix Remaining Test Suites (P2 - COMPLEMENTARY FLOW) #646 - Audit and Fix Remaining Test Suites (P2) complementary-flow

  • ~44 failing test suites (long tail cleanup)
  • Comprehensive audit + systematic fixes

---

🚀 Estrategia de Ejecución: Option C (Hybrid Approach)

Week 1: Baseline Protection + P0 Core Start

Días 1-2:

• ✅ Implementar baseline comparison en completion validator
• ✅ Crear labels (core-flow, complementary-flow, epic:test-stabilization)
• ✅ Crear nuevas issues (Fix OAuth Integration Test Suite (P0 - CORE FLOW) #638-646)
• ✅ Actualizar EPIC 🧪 EPIC: Test Suite Stabilization - Fix Failing Tests for MVP #480 y issues existentes

Días 3-5:

• Fix Fix OAuth Integration Test Suite (P0 - CORE FLOW) #638: OAuth Integration (P0 Core) - 12 horas
• Fix Fix Database Security Test Suite (P0 - SECURITY) #639: Database Security (P0 Security) - 8 horas

Target: <150 failing suites

Week 2: P0 Core Completion

Días 1-3:

• Fix [Test Fix] Ingestor Test Suite - Acknowledgment, Error Handling, Order Processing #481: Ingestor (P0 Core) - 6 horas
• Fix [Test Fix] Shield Test Suite - Stability, UI Integration, Escalation Logic #482 + Pre-existing Shield test failures blocking PRs #633: Shield (P0 Core) - 10 horas

Días 4-5:

• Fix [Test Fix] Roast Generation Test Suite - Core Flow, Validation, Enhanced Features #483: Roast Generation (P0 Core) - 6 horas
• Fix Fix Integration Routes Test Suite (P1 - COMPLEMENTARY FLOW) #641: Integration Routes (P1) - 6 horas

Target: <100 failing suites

Week 3: P1 Bulk Fixes

Días 1-3:

• Fix [Test Fix] Multi-Tenant & Billing Test Suite - RLS, Tier Limits, Stripe Webhooks #484: Multi-Tenant & Billing (P0/P1) - 8 horas
• Fix Fix Tier Validation Service Tests (P1 - COMPLEMENTARY FLOW) #642: Tier Validation (P1) - 4 horas

Días 4-5:

• Fix Fix Frontend/UI Test Suite (P1 - COMPLEMENTARY FLOW) #643: Frontend/UI (P1) - 8 horas
• Fix Fix Worker Test Suite (P1 - COMPLEMENTARY FLOW) #644: Workers (P1) - 10 horas

Target: <50 failing suites

Week 4: P2 Cleanup + Long Tail

Días 1-3:

• Fix [Test Fix] Unit Test Suite - Routes, Middleware, Services (15 files) #485: Unit Tests (P2) - 8 horas
• Fix Fix CLI Test Suite (P2 - COMPLEMENTARY FLOW) #645: CLI (P2) - 3 horas

Días 4-5:

• Fix Audit and Fix Remaining Test Suites (P2 - COMPLEMENTARY FLOW) #646: Remaining Suites (P2) - 16 horas
• Documentation + evidence generation

Target: <10 failing suites ✅ GOAL ACHIEVED

---

📈 Milestones Actualizados

• 🎯 Milestone 1 (Week 1 end): <150 failing suites (16% reduction)
• 🎯 Milestone 2 (Week 2 end): <100 failing suites (44% reduction)
• 🎯 Milestone 3 (Week 3 end): <50 failing suites (72% reduction)
• 🎯 Final Goal (Week 4 end): <10 failing suites (<3% failure rate) ✅

---

✅ Criterios de Éxito

Milestone Final:

• 🎯 <10 failing test suites (<3% failure rate)
• 🎯 Baseline comparison validator implementado
• 🎯 Main branch estable para nuevos PRs
• 🎯 CI pipeline con baseline protection
• 🎯 Documentación completa de fixes

Continuous:

• ✅ Cada PR debe mantener o mejorar baseline
• ✅ PRs no pueden introducir nuevos fallos (regresión detection)
• ✅ Evidencia de testing generada por issue
• ✅ Root cause documented para cada categoría

---

🔗 Referencias

• Analysis Document: docs/test-evidence/EPIC-480-REORGANIZATION.md
• PR fix(tests): Session #11 - Fix auth response structure access - Issue #618 #630 Analysis: docs/test-evidence/issue-618/PR-630-COMPLETION-VALIDATION-ANALYSIS.md
• Related Epic: Testing MVP – Camino de baldosas amarillas (v2) #403 (Testing MVP v2 - nuevas features)
• Quality Standards: CLAUDE.md

---

📊 Tracking Metrics

Baseline (2025-10-23):

{
  "totalSuites": 323,
  "failing": 179,
  "passing": 144,
  "failureRate": 0.554
}

Current Progress: Week 1 in progress (baseline protection + issue creation)

---

Estimación Actualizada: 4 semanas (vs 3 semanas originales)
Esfuerzo Total: ~120 horas técnicas
Prioridad: P0 (CRÍTICO - bloqueante para stability)

[Eibon7]

📋 Sub-Issues Created

Test Fix Tasks:

• [Test Fix] Ingestor Test Suite - Acknowledgment, Error Handling, Order Processing #481 - [Test Fix] Ingestor Test Suite (3 files) - P0
• [Test Fix] Shield Test Suite - Stability, UI Integration, Escalation Logic #482 - [Test Fix] Shield Test Suite (4 files) - P0
• [Test Fix] Roast Generation Test Suite - Core Flow, Validation, Enhanced Features #483 - [Test Fix] Roast Generation Test Suite (3 files) - P0
• [Test Fix] Multi-Tenant & Billing Test Suite - RLS, Tier Limits, Stripe Webhooks #484 - [Test Fix] Multi-Tenant & Billing Test Suite (5 files) - P0 ⏸️ Blocked by Supabase env
• [Test Fix] Unit Test Suite - Routes, Middleware, Services (15 files) #485 - [Test Fix] Unit Test Suite (15 files) - P1

Total: 30 failing test files across 5 issues

Blocker: #484 requires Supabase environment configuration before tests can run.

---

Next Steps:

1. Start with [Test Fix] Ingestor Test Suite - Acknowledgment, Error Handling, Order Processing #481 (Ingestor) and [Test Fix] Shield Test Suite - Stability, UI Integration, Escalation Logic #482 (Shield) - no blockers
2. User configures Supabase env for [Test Fix] Multi-Tenant & Billing Test Suite - RLS, Tier Limits, Stripe Webhooks #484
3. Tackle [Test Fix] Roast Generation Test Suite - Core Flow, Validation, Enhanced Features #483 (Roast) and [Test Fix] Unit Test Suite - Routes, Middleware, Services (15 files) #485 (Unit tests) in parallel