fix: season reward names

Author: FabulousCodingFox

scripts/Makefile

@@ -32,6 +32,7 @@ translations.json:
 
 item_to_name_mappings.json: translations.json
 	curl -sSL "https://github.com/NMSCD/nms-archive/raw/refs/heads/main/$(VERSION)/METADATA/REALITY/TABLES/NMS_REALITY_GCPRODUCTTABLE.MXML" -o ./NMS_REALITY_GCPRODUCTTABLE.MXML
+	curl -sSL "https://github.com/NMSCD/nms-archive/raw/refs/heads/main/$(VERSION)/METADATA/REALITY/TABLES/NMS_BASEPARTPRODUCTS.MXML" -o ./NMS_BASEPARTPRODUCTS.MXML
 	python ./extract_item_names.py
 
 season_rewards.json: item_to_name_mappings.json

scripts/extract_item_names.py

@@ -1,36 +1,43 @@
 import xml.etree.ElementTree as ET
 import json
 
-xml_path = "./NMS_REALITY_GCPRODUCTTABLE.MXML"
+xml_paths = [
+    "./NMS_REALITY_GCPRODUCTTABLE.MXML",
+    "./NMS_BASEPARTPRODUCTS.MXML"
+]
 translations_path = "./translations.json"
 output_json = "item_to_name_mappings.json"
 
 # Load translation strings
 with open(translations_path, "r", encoding="utf-8") as f:
     translations = json.load(f)
 
-tree = ET.parse(xml_path)
-root = tree.getroot()
-
 mapping = {}
 
-# Find all product entries
-for product in root.findall(".//Property[@name='Table'][@value='GcProductData']"):
-    prod_id = None
-    name_lower_key = None
+def process_xml(xml_path):
+    tree = ET.parse(xml_path)
+    root = tree.getroot()
+
+    # Find all product entries
+    for product in root.findall(".//Property[@name='Table'][@value='GcProductData']"):
+        prod_id = None
+        name_lower_key = None
 
-    for prop in product.findall("Property"):
-        if prop.get("name") == "ID":
-            prod_id = prop.get("value")
-        if prop.get("name") == "NameLower":
-            name_lower_key = prop.get("value")
+        for prop in product.findall("Property"):
+            if prop.get("name") == "ID":
+                prod_id = prop.get("value")
+            if prop.get("name") == "NameLower":
+                name_lower_key = prop.get("value")
 
-    if prod_id and name_lower_key:
-        translated_value = translations.get(name_lower_key, name_lower_key)
-        mapping[prod_id] = translated_value
+        if prod_id and name_lower_key:
+            translated_value = translations.get(name_lower_key, name_lower_key)
+            mapping[prod_id] = translated_value
+
+# Process both XMLs
+for path in xml_paths:
+    process_xml(path)
 
 with open(output_json, "w", encoding="utf-8") as f:
     json.dump(mapping, f, indent=4, ensure_ascii=False)
 
-print(f"Saved {len(mapping)} entries to {output_json}")
-
+print(f"Saved {len(mapping)} combined entries to {output_json}")

src/data/rewards/season.json

@@ -1,16 +1,16 @@
 [
   {
-    "name": "B_WNG_P",
+    "name": "Aeron Drive",
     "id": "^B_WNG_P",
     "expedition": 20
   },
   {
-    "name": "B_WNG_R",
+    "name": "Aeron Blade",
     "id": "^B_WNG_R",
     "expedition": 20
   },
   {
-    "name": "B_STR_AA_N",
+    "name": "Aeron Winglet",
     "id": "^B_STR_AA_N",
     "expedition": 20
   },
@@ -30,32 +30,32 @@
     "expedition": 20
   },
   {
-    "name": "B_WNG_Q",
+    "name": "Wings of Aeron",
     "id": "^B_WNG_Q",
     "expedition": 20
   },
   {
-    "name": "B_DECO_S",
+    "name": "Aeron Pillar",
     "id": "^B_DECO_S",
     "expedition": 20
   },
   {
-    "name": "B_DECO_T",
+    "name": "Aeron Pyramid",
     "id": "^B_DECO_T",
     "expedition": 20
   },
   {
-    "name": "B_SHL_E",
+    "name": "Aeron Powershield",
     "id": "^B_SHL_E",
     "expedition": 20
   },
   {
-    "name": "B_DECO_R",
+    "name": "Aeron Cowling",
     "id": "^B_DECO_R",
     "expedition": 20
   },
   {
-    "name": "B_DECO_Q_0",
+    "name": "Aeron Diffuser",
     "id": "^B_DECO_Q_0",
     "expedition": 20
   },
@@ -100,7 +100,7 @@
     "expedition": 19
   },
   {
-    "name": "B_TUR_B",
+    "name": "Deadeye Cannon",
     "id": "^B_TUR_B",
     "expedition": 19
   },
@@ -1184,4 +1184,4 @@
     "id": "^EXPD_FIREPACK01",
     "expedition": 1
   }
-]
+]