Add async operations to serializer. Add ability to get read or write streams from IFileStorage #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@benaadams what do you think about these changes? |
|
I wasn't sure what changing the interface would do compat wise and if that would be a problem :) For the file interface is there a problem with some of the file providers as they have upload blob type implementations rather than stream based? |
Contributor
Author
|
Generally, I just try to keep source compat which we can do with extension methods. Yeah, I think we can make the blob based file providers that require a single PUT operations work one way or another. Worst case scenario we can return a memorystream that on dispose does the blob PUT operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.