Fixing tool failures crashing runners in failover answer (#808)

jamesbraza · web-flow · commit af2871ee4ca0 · 2025-01-10T14:33:17.000-08:00
diff --git a/paperqa/agents/main.py b/paperqa/agents/main.py
@@ -166,10 +166,11 @@ async def _run_with_timeout_failure(
         generate_answer_tool = next(
             filter(lambda x: x.info.name == GenerateAnswer.TOOL_FN_NAME, env.tools)
         )
-        await generate_answer_tool._tool_fn(state=env.state)
-        env.state.record_action(
-            ToolRequestMessage(tool_calls=[ToolCall.from_tool(generate_answer_tool)])
+        action = ToolRequestMessage(
+            tool_calls=[ToolCall.from_tool(generate_answer_tool)]
         )
+        await env.exec_tool_calls(message=action, state=env.state, handle_tool_exc=True)
+        env.state.record_action(action)
     return env.state.session, status
 
 

Original file line number	Diff line number	Diff line change
`@@ -166,10 +166,11 @@ async def _run_with_timeout_failure(`
`166`	`166`	`generate_answer_tool = next(`
`167`	`167`	`filter(lambda x: x.info.name == GenerateAnswer.TOOL_FN_NAME, env.tools)`
`168`	`168`	`)`
`169`		`- await generate_answer_tool._tool_fn(state=env.state)`
`170`		`- env.state.record_action(`
`171`		`- ToolRequestMessage(tool_calls=[ToolCall.from_tool(generate_answer_tool)])`
	`169`	`+ action = ToolRequestMessage(`
	`170`	`+ tool_calls=[ToolCall.from_tool(generate_answer_tool)]`
`172`	`171`	`)`
	`172`	`+ await env.exec_tool_calls(message=action, state=env.state, handle_tool_exc=True)`
	`173`	`+ env.state.record_action(action)`
`173`	`174`	`return env.state.session, status`
`174`	`175`
`175`	`176`