Skip to content

Commit ee88746

Browse files
authored
Merge branch 'develop' into feature/mathomp4/v11-cleanup-setup
2 parents 06c2d20 + 329ab6d commit ee88746

File tree

2 files changed

+36
-83
lines changed

2 files changed

+36
-83
lines changed

DynCore_GridCompMod.F90

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,6 +1046,15 @@ Subroutine SetServices ( gc, rc )
10461046
VLOCATION = MAPL_VLocationEdge, RC=STATUS )
10471047
VERIFY_(STATUS)
10481048

1049+
call MAPL_AddExportSpec ( gc, &
1050+
SHORT_NAME = 'MZ', &
1051+
LONG_NAME = 'vertical_mass_flux', &
1052+
UNITS = 'kg m-2 s-1', &
1053+
PRECISION = ESMF_KIND_R4, &
1054+
DIMS = MAPL_DimsHorzVert, &
1055+
VLOCATION = MAPL_VLocationEdge, RC=STATUS )
1056+
VERIFY_(STATUS)
1057+
10491058
call MAPL_AddExportSpec ( gc, &
10501059
SHORT_NAME = 'PV', &
10511060
LONG_NAME = 'ertels_isentropic_potential_vorticity', &
@@ -4533,6 +4542,7 @@ subroutine Run(gc, import, export, clock, rc)
45334542
! Compute and return the vertical mass flux
45344543
call getVerticalMassFlux(mfxxyz, mfyxyz, mfzxyz, dt)
45354544
call FILLOUT3r8 (export, 'MFZ' , mfzxyz , rc=status); VERIFY_(STATUS)
4545+
call FILLOUT3 (export, 'MZ' , mfzxyz , rc=status); VERIFY_(STATUS)
45364546

45374547
call FILLOUT3 (export, 'U' , ur , rc=status); VERIFY_(STATUS)
45384548
call FILLOUT3 (export, 'V' , vr , rc=status); VERIFY_(STATUS)

scripts/fv3_setup

Lines changed: 26 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -290,49 +290,30 @@ ASKPROC:
290290

291291
if ( $SITE == 'NCCS' ) then
292292

293-
set BUILT_ON_SLES15 = @BUILT_ON_SLES15@
294-
295-
if ("$BUILT_ON_SLES15" == "TRUE") then
296-
echo "Enter the ${C1}Processor Type${CN} you wish to run on:"
297-
echo " ${C2}mil (Milan)${CN} (default)"
298-
echo " "
299-
set MODEL = `echo $<`
300-
set MODEL = `echo $MODEL | tr "[:upper:]" "[:lower:]"`
301-
if ( .$MODEL == .) then
302-
set MODEL = 'mil'
303-
endif
304-
305-
if( $MODEL != 'mil' ) goto ASKPROC
306-
307-
if ($MODEL == 'mil') then
308-
# We save a couple processes for the kernel
309-
set NCPUS_PER_NODE = 126
310-
endif
311-
else
312-
echo "Enter the ${C1}Processor Type${CN} you wish to run on:"
313-
echo " ${C2}sky (Skylake)${CN}"
314-
echo " ${C2}cas (Cascade Lake) (default)${CN}"
315-
echo " "
316-
set MODEL = `echo $<`
317-
set MODEL = `echo $MODEL | tr "[:upper:]" "[:lower:]"`
318-
if ( .$MODEL == .) then
319-
set MODEL = 'cas'
320-
endif
293+
echo "Enter the ${C1}Processor Type${CN} you wish to run on:"
294+
echo " ${C2}mil (Milan)${CN} (default)"
295+
echo " ${C2}cas (Cascade Lake)${CN}"
296+
echo " "
297+
set MODEL = `echo $<`
298+
set MODEL = `echo $MODEL | tr "[:upper:]" "[:lower:]"`
299+
if ( .$MODEL == .) then
300+
set MODEL = 'mil'
301+
endif
321302

322-
if( $MODEL != 'sky' & \
323-
$MODEL != 'cas' ) goto ASKPROC
324-
325-
if ($MODEL == 'sky') then
326-
set NCPUS_PER_NODE = 40
327-
else if ($MODEL == 'cas') then
328-
# NCCS currently recommends that users do not run with
329-
# 48 cores per node on SCU16 due to OS issues and
330-
# recommends that CPU-intensive works run with 46 or less
331-
# cores. As 45 is a multiple of 3, it's the best value
332-
# that doesn't waste too much
333-
#set NCPUS_PER_NODE = 48
334-
set NCPUS_PER_NODE = 45
335-
endif
303+
if( $MODEL != 'mil' & \
304+
$MODEL != 'cas' ) goto ASKPROC
305+
306+
if ($MODEL == 'mil') then
307+
# We save a couple processes for the kernel
308+
set NCPUS_PER_NODE = 126
309+
else if ($MODEL == 'cas') then
310+
# NCCS currently recommends that users do not run with
311+
# 48 cores per node on SCU16 due to OS issues and
312+
# recommends that CPU-intensive works run with 46 or less
313+
# cores. As 45 is a multiple of 3, it's the best value
314+
# that doesn't waste too much
315+
#set NCPUS_PER_NODE = 48
316+
set NCPUS_PER_NODE = 45
336317
endif
337318

338319
else if ( $SITE == 'NAS' ) then
@@ -804,51 +785,13 @@ EOF
804785
if ( $SITE == 'NCCS' ) then
805786

806787
cat >> $EXPDIR/SETENV.commands << EOF
807-
setenv I_MPI_SHM_HEAP_VSIZE 512
808-
setenv PSM2_MEMORY large
809-
EOF
810-
811-
# Testing at NCCS showed these caused a crash at higher resolutions at
812-
# restart read
813-
if ( $USING_SINGULARITY == FALSE ) then
814-
815-
cat >> $EXPDIR/SETENV.commands << EOF
816-
setenv I_MPI_EXTRA_FILESYSTEM 1
817-
setenv I_MPI_EXTRA_FILESYSTEM_FORCE gpfs
818-
EOF
788+
setenv I_MPI_ADJUST_ALLREDUCE 12
789+
setenv I_MPI_ADJUST_GATHERV 3
819790
820-
endif # if NOT Singularity
821-
822-
# Testing by Bill Putman found these to be
823-
# useful flags with Intel MPI on SLES15 on the
824-
# Milan nodes.
825-
# Note 1: Testing by NCCS shows the PSM3 provider
826-
# runs on the Infiniband fabric. Tests show it runs
827-
# up to C720.
828-
# Note 2: When the Cascade Lakes are moved to
829-
# SLES15, these will need to be Milan-only flags
830-
# as Intel MPI will probably work just fine with
831-
# Intel chips.
832-
if ("$BUILT_ON_SLES15" == "TRUE") then
833-
cat >> $EXPDIR/SETENV.commands << EOF
834-
setenv I_MPI_FALLBACK 0
835-
setenv I_MPI_FABRICS ofi
791+
setenv I_MPI_FABRICS shm:ofi
836792
setenv I_MPI_OFI_PROVIDER psm3
837-
setenv I_MPI_ADJUST_SCATTER 2
838-
setenv I_MPI_ADJUST_SCATTERV 2
839-
setenv I_MPI_ADJUST_GATHER 2
840-
setenv I_MPI_ADJUST_GATHERV 3
841-
setenv I_MPI_ADJUST_ALLGATHER 3
842-
setenv I_MPI_ADJUST_ALLGATHERV 3
843-
setenv I_MPI_ADJUST_ALLREDUCE 12
844-
setenv I_MPI_ADJUST_REDUCE 10
845-
setenv I_MPI_ADJUST_BCAST 11
846-
setenv I_MPI_ADJUST_REDUCE_SCATTER 4
847-
setenv I_MPI_ADJUST_BARRIER 9
848793
EOF
849794

850-
endif # if SLES15
851-
852795
endif # if NCCS
853796

854797
endif # if mpi

0 commit comments

Comments
 (0)