Skip to content

Conversation

@martijnrusschen
Copy link
Member

@martijnrusschen martijnrusschen commented Dec 1, 2025

Fixes #4332

  • Modified handleTimeChange to properly handle range mode
  • When only startDate is selected, time is applied to startDate
  • When both dates are selected, time is applied to endDate
  • onChange is called with proper [Date, Date] tuple format
  • Added 6 tests for the fix

- Modified handleTimeChange to properly handle range mode
- When only startDate is selected, time is applied to startDate
- When both dates are selected, time is applied to endDate
- onChange is called with proper [Date, Date] tuple format
- Added 6 tests for the fix
@martijnrusschen martijnrusschen force-pushed the fix/show-time-select-with-selects-range-4332 branch from 1282b39 to 0d7812f Compare December 1, 2025 09:02
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.22%. Comparing base (649af62) to head (0d7812f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6074   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          30       30           
  Lines        3597     3612   +15     
  Branches     1543     1531   -12     
=======================================
+ Hits         3569     3584   +15     
  Misses         27       27           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit f11433c into main Dec 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

showTimeSelect does not work when working with ranges.

2 participants