-
-
Notifications
You must be signed in to change notification settings - Fork 496
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
When APP_SAAS_MODE_ENABLED=false, the Getting Started page always displays the âConnect with Stripeâ step as incomplete. Clicking it navigates to /account/payment, but the âPayment & Planâ tab is hidden in nonâSaaS mode, so the router ends up at /account/undefined. There is no way to complete or dismiss the step in this mode.
To Reproduce
- Set backend env var
APP_SAAS_MODE_ENABLED=false. - Deploy and sign in.
- Create an event and open Getting Started:
/manage/event/{eventId}/getting-started. - Observe the âConnect with Stripeâ card shown as incomplete.
- Click âConnect with Stripeâ â redirected to
/account/paymentâ UI lands on/account/undefined.
Expected behavior
- When SaaS mode is disabled, the Stripe Connect step should be hidden (or disabled with a clear explanation).
- No navigation to
/account/paymentin nonâSaaS mode. - Getting Started progress should not be blocked by Stripe Connect when SaaS is off.
Screenshots
Desktop (please complete)
- OS: macOS 15
- Browser: Dia 0.47.0 (68786)
Hi.Events Version and platform
- Version: 1.1.0-beta-2 (production deployment)
- Platform: DigitalOcean App Platform
Additional context
Likely UI gating issue.
- Network:
GET /api/accountsreturns account JSON withoutstripe_account_idorstripe_connect_setup_completewhen SaaS mode is off. - Console: No runtime errors; navigation results in
/account/undefinedbecause the âPayment & Planâ tab is conditionally hidden. - Backend context:
backend/app/Resources/Account/AccountResource.phponly includes Stripe fields whenconfig('app.saas_mode_enabled')is true.- The âPayment & Planâ tab renders only when
account.is_saas_mode_enabledis true, so the route has no matching tab when false.
Proposed fix:
- On Getting Started, render the Stripe card only when
account.is_saas_mode_enabled === true. - Guard navigation to
/account/paymentwhen SaaS mode is disabled. - Optional: add an integration test to ensure the card does not render in nonâSaaS mode.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working