Merge pull request #20860 from hyuraku/tab-install-status-type-safety

refactor: update type signatures to always return boolean for install…

Author: MikeMcQuaid

Library/Homebrew/tab.rb

@@ -19,13 +19,13 @@ class AbstractTab
   # Check whether the formula or cask was installed as a dependency.
   #
   # @api internal
-  sig { returns(T.nilable(T::Boolean)) } # TODO: change this to always return a boolean
+  sig { returns(T::Boolean) }
   attr_accessor :installed_as_dependency
 
   # Check whether the formula or cask was installed on request.
   #
   # @api internal
-  sig { returns(T.nilable(T::Boolean)) } # TODO: change this to always return a boolean
+  sig { returns(T::Boolean) }
   attr_accessor :installed_on_request
 
   sig { returns(T.nilable(String)) }
@@ -41,8 +41,10 @@ class AbstractTab
   # TODO: Update attributes to only accept symbol keys (kwargs style).
   sig { params(attributes: T.any(T::Hash[String, T.untyped], T::Hash[Symbol, T.untyped])).void }
   def initialize(attributes = {})
-    @installed_as_dependency = T.let(nil, T.nilable(T::Boolean))
-    @installed_on_request = T.let(nil, T.nilable(T::Boolean))
+    @installed_as_dependency = T.let(false, T::Boolean)
+    @installed_on_request = T.let(false, T::Boolean)
+    @installed_as_dependency_present = T.let(false, T::Boolean)
+    @installed_on_request_present = T.let(false, T::Boolean)
     @homebrew_version = T.let(nil, T.nilable(String))
     @tabfile = T.let(nil, T.nilable(Pathname))
     @loaded_from_api = T.let(nil, T.nilable(T::Boolean))
@@ -54,6 +56,12 @@ def initialize(attributes = {})
 
     attributes.each do |key, value|
       case key.to_sym
+      when :installed_as_dependency
+        @installed_as_dependency = value
+        @installed_as_dependency_present = true
+      when :installed_on_request
+        @installed_on_request = value
+        @installed_on_request_present = true
       when :changed_files
         @changed_files = value&.map { |f| Pathname(f) }
       else
@@ -548,4 +556,10 @@ def to_s
     end
     s.join(" ")
   end
+
+  sig { returns(T::Boolean) }
+  def installed_on_request_present? = @installed_on_request_present
+
+  sig { returns(T::Boolean) }
+  def installed_as_dependency_present? = @installed_as_dependency_present
 end

Library/Homebrew/test/utils/autoremove_spec.rb

@@ -96,21 +96,21 @@
     end
 
     specify "installed on request" do
-      allow(tab_from_keg).to receive(:installed_on_request).and_return(true)
+      allow(tab_from_keg).to receive_messages(installed_on_request: true, installed_on_request_present?: true)
 
       expect(described_class.send(:unused_formulae_with_no_formula_dependents, formulae))
         .to eq([])
     end
 
     specify "not installed on request" do
-      allow(tab_from_keg).to receive(:installed_on_request).and_return(false)
+      allow(tab_from_keg).to receive_messages(installed_on_request: false, installed_on_request_present?: true)
 
       expect(described_class.send(:unused_formulae_with_no_formula_dependents, formulae))
         .to match_array(formulae)
     end
 
     specify "installed on request is null" do
-      allow(tab_from_keg).to receive(:installed_on_request).and_return(nil)
+      allow(tab_from_keg).to receive_messages(installed_on_request: false, installed_on_request_present?: false)
 
       expect(described_class.send(:unused_formulae_with_no_formula_dependents, formulae))
         .to eq([])

Library/Homebrew/utils/autoremove.rb

@@ -68,7 +68,11 @@ def bottled_formulae_with_no_formula_dependents(formulae)
       sig { params(formulae: T::Array[Formula]).returns(T::Array[Formula]) }
       def unused_formulae_with_no_formula_dependents(formulae)
         unused_formulae = bottled_formulae_with_no_formula_dependents(formulae).select do |f|
-          f.any_installed_keg&.tab&.installed_on_request == false
+          tab = f.any_installed_keg&.tab
+          next unless tab
+          next unless tab.installed_on_request_present?
+
+          tab.installed_on_request == false
         end
 
         unless unused_formulae.empty?