Skip to content

Conversation

@ozeranskii
Copy link
Contributor

@ozeranskii ozeranskii commented Oct 24, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 24, 2025
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 24, 2025
@ozeranskii ozeranskii force-pushed the httptap-0.1.0 branch 2 times, most recently from 0b2c7bd to 1bff736 Compare October 24, 2025 23:33
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 24, 2025
Copy link
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice piece of software, but it currently does not meet the notability requirements for inclusion into Homebrew-core: https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff. Not to mention it is too new (Homebrew requires new formulae to be available for at least 30 days before they can be included in the core repository).

Seems like people are interested in this software (judging how it got almost 30 stars in a few days). We will be glad to add it one month later (if it has enough stars/forks/watchers). For now you can create and maintain your own tap:

@botantony botantony added the notability Project is not notable enough for inclusion label Oct 24, 2025
@botantony botantony marked this pull request as draft October 25, 2025 00:52
@daeho-ro
Copy link
Member

daeho-ro commented Oct 25, 2025

There was a PR and eventually failed with linux

@botantony
Copy link
Member

@daeho-ro these are different programs, just with the same name

@daeho-ro
Copy link
Member

🤦‍♂️

@botantony botantony added CI-skip-new-formulae Pass --skip-new to brew test-bot. and removed notability Project is not notable enough for inclusion labels Oct 27, 2025
@botantony
Copy link
Member

Adding CI-skip-new-formulae Pass --skip-new to brew test-bot. to pass 30 days requirements

@botantony botantony marked this pull request as ready for review October 27, 2025 18:46
Copilot AI review requested due to automatic review settings October 27, 2025 18:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Homebrew formula for httptap version 0.1.0, a Python-based HTTP request visualizer with phase-by-phase timing breakdown. The formula installs the tool and its dependencies using Python's virtualenv.

Key changes:

  • New formula implementing Python virtualenv installation for httptap 0.1.0
  • Includes 14 Python package dependencies (anyio, certifi, dnspython, h11, h2, hpack, httpcore, httpx, hyperframe, idna, markdown-it-py, mdurl, pygments, rich, sniffio)
  • Implements version checking via PyPI livecheck strategy and basic version test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2025
@ozeranskii ozeranskii changed the title httptap 0.1.0 (new formula) httptap 0.1.1 (new formula) Oct 27, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2025
@ozeranskii ozeranskii requested a review from botantony October 27, 2025 21:53
Copy link
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cange commit message to httptap 0.1.1 (new formula)?

@ozeranskii ozeranskii force-pushed the httptap-0.1.0 branch 4 times, most recently from 5b1821a to 6eb2418 Compare October 27, 2025 22:43
@ozeranskii ozeranskii requested a review from botantony October 27, 2025 22:44
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Oct 27, 2025
build(formula): switch to sdist and vendor Python resources for httptap

Replace installation from a prebuilt wheel with installation from the source distribution and vendored Python resources. This enables Homebrew to create a virtualenv and install all declared dependencies reliably, improving reproducibility and auditability of the package. Also set a default SOURCE_DATE_EPOCH to ensure deterministic builds.

The change adds explicit Python dependency resources and uses the virtualenv installer to manage them, replacing the previous pip-install-from-wheel approach and keeping the existing runtime test intact.

build(formula): add wheel-based httptap formula using [email protected]

Add a Homebrew formula that installs httptap from a prebuilt wheel via a Python 3.14 virtualenv.
Switch from a source-based formula with numerous vendored Python resources to a simpler wheel-based install to reduce maintenance and dependency pinning while preserving the existing test coverage.

This simplifies installation and improves determinism by relying on the published wheel and [email protected] runtime.

build(formula): use virtualenv_install_with_resources and add rust dependency

Replace manual virtualenv creation and pip_install_and_link with virtualenv_install_with_resources to streamline Python package installation and ensure resources are installed and linked correctly. Add rust as a build dependency to satisfy crates-backed wheels or build steps that require Rust. Retains the SOURCE_DATE_EPOCH setting for reproducible builds.

f
Copy link
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@ozeranskii
Copy link
Contributor Author

All the checks have finally been successfully completed.

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 27, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 27, 2025 23:37
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 27, 2025
Merged via the queue into Homebrew:main with commit 6a21878 Oct 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants