Skip to content

Conversation

@botantony
Copy link
Member

@botantony botantony commented Oct 27, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@botantony botantony added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 27, 2025
Copilot AI review requested due to automatic review settings October 27, 2025 13:05
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates formula definitions from the centralized pypi_formula_mappings.json file to use the inline PyPI DSL (pypi_packages) directly within each formula file. This change improves maintainability by colocating package configuration with the formulas that use them.

  • Removes entries from pypi_formula_mappings.json for formulas beginning with "a"
  • Adds pypi_packages DSL calls to each corresponding formula file
  • Maintains identical functionality by preserving all exclude_packages and extra_packages configurations

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pypi_formula_mappings.json Removed configuration entries for formulas starting with "a"
Formula/a/abi3audit.rb Added inline PyPI DSL to exclude certifi
Formula/a/acronym.rb Added inline PyPI DSL to exclude numpy
Formula/a/aider.rb Added inline PyPI DSL to exclude certifi and pillow
Formula/a/aiven-client.rb Added inline PyPI DSL to exclude certifi
Formula/a/alot.rb Added inline PyPI DSL to exclude notmuch2 and include standard-mailcap
Formula/a/animdl.rb Added inline PyPI DSL to exclude certifi
Formula/a/ansible-lint.rb Added inline PyPI DSL to exclude cryptography
Formula/a/apprise.rb Added inline PyPI DSL to exclude certifi
Formula/a/aqtinstall.rb Added inline PyPI DSL to exclude certifi
Formula/a/arcade-learning-environment.rb Added inline PyPI DSL to exclude numpy and include gymnasium
Formula/a/archgw.rb Added inline PyPI DSL to exclude multiple packages and include filelock
Formula/a/arjun.rb Added inline PyPI DSL to exclude certifi
Formula/a/arxiv_latex_cleaner.rb Added inline PyPI DSL to exclude pillow
Formula/a/astrometry-net.rb Added inline PyPI DSL to exclude numpy and include fitsio
Formula/a/aws-elasticbeanstalk.rb Added inline PyPI DSL to exclude certifi and cryptography
Formula/a/aws-google-auth.rb Added inline PyPI DSL to exclude certifi and pillow
Formula/a/aws-sam-cli.rb Added inline PyPI DSL to exclude multiple packages
Formula/a/aws-sso-util.rb Added inline PyPI DSL to exclude certifi
Formula/a/awscli.rb Added inline PyPI DSL to include flit-core
Formula/a/awscurl.rb Added inline PyPI DSL to exclude certifi and cryptography

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@botantony botantony force-pushed the a-formulae-pypi-dsl branch 3 times, most recently from c03c570 to 5fc3db9 Compare October 27, 2025 13:24
@chenrui333
Copy link
Member

some conflict with pypi_formula_mappings.json

Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
@botantony botantony force-pushed the a-formulae-pypi-dsl branch from 5fc3db9 to 3092fb6 Compare October 27, 2025 14:59
@chenrui333 chenrui333 added this pull request to the merge queue Oct 27, 2025
@chenrui333
Copy link
Member

:shipit:

Merged via the queue into main with commit a1e3157 Oct 27, 2025
24 checks passed
@chenrui333 chenrui333 deleted the a-formulae-pypi-dsl branch October 27, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants