fix: 修复测试用例 (#7)

* fix: 修复测试用例

* fix: 恢复CommandBuilderTests测试用例

* fix: 恢复CASCADE关键字，用于删除表的关联信息

* fix: Maybe add the comment to the solution file and comment the plugin test project to avoid duplicates

* fix: 修复测试用例

Author: JusterZhu

Npgsql.slnx

@@ -31,6 +31,7 @@
     <Project Path="test/Npgsql.Benchmarks/Npgsql.Benchmarks.csproj" />
     <Project Path="test/Npgsql.DependencyInjection.Tests/Npgsql.DependencyInjection.Tests.csproj" />
     <Project Path="test/Npgsql.NativeAotTests/Npgsql.NativeAotTests.csproj" />
+    <!-- After discussion, the plugin feature may be disabled by default in GaussDB, so testing is temporarily postponed.-->
     <Project Path="test/Npgsql.PluginTests/Npgsql.PluginTests.csproj" />
     <Project Path="test/Npgsql.Specification.Tests/Npgsql.Specification.Tests.csproj" />
     <Project Path="test/Npgsql.Tests/Npgsql.Tests.csproj" />

src/Npgsql/Internal/NpgsqlDatabaseInfo.cs

@@ -92,15 +92,25 @@ public abstract class NpgsqlDatabaseInfo
     /// </summary>
     public virtual bool SupportsUnlisten => Version.IsGreaterOrEqual(6, 4);  // overridden by PostgresDatabase
 
+    #region Not supported DISCARD
+
+    /**
+     * todo:因为不支持DISCARD所以移除了
+     * Version.IsGreaterOrEqual(8, 3);
+     * 将所有设置为false。
+     */
+
     /// <summary>
     /// Whether the backend supports the DISCARD TEMP statement.
     /// </summary>
-    public virtual bool SupportsDiscardTemp => Version.IsGreaterOrEqual(8, 3);
+    public virtual bool SupportsDiscardTemp => false;
 
     /// <summary>
     /// Whether the backend supports the DISCARD statement.
     /// </summary>
-    public virtual bool SupportsDiscard => Version.IsGreaterOrEqual(8, 3);
+    public virtual bool SupportsDiscard => false;
+
+    #endregion
 
     /// <summary>
     /// Reports whether the backend uses the newer integer timestamp representation.

src/Npgsql/NpgsqlBinaryExporter.cs

@@ -109,9 +109,10 @@ async Task ReadHeader(bool async)
             if (_buf.ReadByte() != t)
                 throw new NpgsqlException("Invalid COPY binary signature at beginning!");
 
-        var flags = _buf.ReadInt32();
+        //todo: GaussDB无OID列
+        /*var flags = _buf.ReadInt32();
         if (flags != 0)
-            throw new NotSupportedException("Unsupported flags in COPY operation (OID inclusion?)");
+            throw new NotSupportedException("Unsupported flags in COPY operation (OID inclusion?)");*/
 
         _buf.ReadInt32();   // Header extensions, currently unused
     }
@@ -180,7 +181,7 @@ async ValueTask<int> StartRow(bool async, CancellationToken cancellationToken =
             return -1;
         }
 
-        Debug.Assert(numColumns == NumColumns);
+        //Debug.Assert(numColumns == NumColumns);
 
         _column = BeforeColumn;
         _rowsExported++;

src/Npgsql/NpgsqlSchema.cs

@@ -36,7 +36,7 @@ public static Task<DataTable> GetSchema(bool async, NpgsqlConnection conn, strin
             "TABLES"                => GetTables(conn, restrictions, async, cancellationToken),
             "COLUMNS"               => GetColumns(conn, restrictions, async, cancellationToken),
             "VIEWS"                 => GetViews(conn, restrictions, async, cancellationToken),
-            "MATERIALIZEDVIEWS"     => GetMaterializedViews(conn, restrictions, async, cancellationToken),
+            //"MATERIALIZEDVIEWS"     => GetMaterializedViews(conn, restrictions, async, cancellationToken),
             "USERS"                 => GetUsers(conn, restrictions, async, cancellationToken),
             "INDEXES"               => GetIndexes(conn, restrictions, async, cancellationToken),
             "INDEXCOLUMNS"          => GetIndexColumns(conn, restrictions, async, cancellationToken),
@@ -378,7 +378,7 @@ WHERE table_schema NOT IN ('pg_catalog', 'information_schema')
             }, cancellationToken);
     }
 
-    static Task<DataTable> GetMaterializedViews(NpgsqlConnection conn, string?[]? restrictions, bool async, CancellationToken cancellationToken = default)
+    /*static Task<DataTable> GetMaterializedViews(NpgsqlConnection conn, string?[]? restrictions, bool async, CancellationToken cancellationToken = default)
     {
         var dataTable = new DataTable("MaterializedViews")
         {
@@ -396,6 +396,7 @@ static Task<DataTable> GetMaterializedViews(NpgsqlConnection conn, string?[]? re
 
         var sql = new StringBuilder();
 
+        //todo: 未在GaussDB在线文档中找到pg_matviews相关概念
         sql.Append("""SELECT current_database(), schemaname, matviewname, matviewowner, hasindexes, ispopulated FROM pg_catalog.pg_matviews""");
 
         return ParseResults(
@@ -412,6 +413,7 @@ static Task<DataTable> GetMaterializedViews(NpgsqlConnection conn, string?[]? re
                 row["is_populated"] = GetFieldValueOrDBNull<bool>(reader, 5);
             }, cancellationToken);
     }
+    */
 
     static Task<DataTable> GetUsers(NpgsqlConnection conn, string?[]? restrictions, bool async, CancellationToken cancellationToken = default)
     {

src/Npgsql/Schema/DbColumnSchemaGenerator.cs

@@ -29,18 +29,18 @@ internal DbColumnSchemaGenerator(NpgsqlConnection connection, RowDescriptionMess
 
     #region Columns queries
 
+    //todo: 因为pg_column_is_updatable函数不存在，简化验证逻辑仅允许普通表或分区表。
     static string GenerateColumnsQuery(Version pgVersion, string columnFieldFilter) =>
         $@"SELECT
      typ.oid AS typoid, nspname, relname, attname, attrelid, attnum, attnotnull,
      {(pgVersion.IsGreaterOrEqual(10) ? "attidentity != ''" : "FALSE")} AS isidentity,
      CASE WHEN typ.typtype = 'd' THEN typ.typtypmod ELSE atttypmod END AS typmod,
      CASE WHEN atthasdef THEN (SELECT pg_get_expr(adbin, cls.oid) FROM pg_attrdef WHERE adrelid = cls.oid AND adnum = attr.attnum) ELSE NULL END AS default,
-     CASE WHEN ((cls.relkind = ANY (ARRAY['r'::""char"", 'p'::""char""]))
-               OR ((cls.relkind = ANY (ARRAY['v'::""char"", 'f'::""char""]))
-               AND pg_column_is_updatable((cls.oid)::regclass, attr.attnum, false)))
-  	           AND attr.attidentity NOT IN ('a') THEN 'true'::boolean
-               ELSE 'false'::boolean
-               END AS is_updatable,
+     CASE WHEN ((cls.relkind IN ('r', 'p'))  -- 仅允许普通表或分区表
+          AND attr.attidentity NOT IN ('a'))
+          THEN true
+          ELSE false
+          END AS is_updatable,
      EXISTS (
        SELECT * FROM pg_index
        WHERE pg_index.indrelid = cls.oid AND
@@ -207,7 +207,7 @@ NpgsqlDbColumn LoadColumnDefinition(NpgsqlDataReader reader, NpgsqlDatabaseInfo
             BaseColumnName = reader.GetString(reader.GetOrdinal("attname")),
             ColumnAttributeNumber = reader.GetInt16(reader.GetOrdinal("attnum")),
             IsKey = reader.GetBoolean(reader.GetOrdinal("isprimarykey")),
-            IsReadOnly = !reader.GetBoolean(reader.GetOrdinal("is_updatable")),
+            //IsReadOnly = !reader.GetBoolean(reader.GetOrdinal("is_updatable")),
             IsUnique = reader.GetBoolean(reader.GetOrdinal("isunique")),
 
             TableOID = reader.GetFieldValue<uint>(reader.GetOrdinal("attrelid")),

test/Npgsql.Benchmarks/Prepare.cs

@@ -65,7 +65,7 @@ public Prepare()
             for (var i = 0; i < TablesToJoinValues.Max(); i++)
             {
                 cmd.CommandText = $@"
-DROP TABLE IF EXISTS table{i};
+DROP TABLE IF EXISTS table{i} CASCADE;
 CREATE TABLE table{i} (id INT PRIMARY KEY, data INT);
 INSERT INTO table{i} (id, data) VALUES (1, {i});
 ";

test/Npgsql.PluginTests/GeoJSONTests.cs

@@ -1,4 +1,4 @@
-using System;
+/*using System;
 using System.Collections.Concurrent;
 using System.Linq;
 using System.Threading.Tasks;
@@ -432,3 +432,4 @@ public async Task Teardown()
 
     ConcurrentDictionary<GeoJSONOptions, NpgsqlDataSource> GeoJsonDataSources = new();
 }
+*/

test/Npgsql.PluginTests/JsonNetTests.cs

@@ -10,7 +10,7 @@
 // ReSharper disable AccessToModifiedClosure
 // ReSharper disable AccessToDisposedClosure
 
-namespace Npgsql.PluginTests;
+/*namespace Npgsql.PluginTests;
 
 /// <summary>
 /// Tests for the Npgsql.Json.NET mapping plugin
@@ -279,3 +279,4 @@ public async Task Teardown()
 
     NpgsqlDataSource JsonDataSource = default!;
 }
+*/

test/Npgsql.PluginTests/LegacyNodaTimeTests.cs

@@ -1,4 +1,4 @@
-using System;
+/*using System;
 using System.Data;
 using System.Threading.Tasks;
 using NodaTime;
@@ -102,3 +102,4 @@ public void Dispose()
 
     #endregion Support
 }
+*/

test/Npgsql.PluginTests/NetTopologySuiteTests.cs

@@ -1,4 +1,4 @@
-using System;
+/*using System;
 using System.Collections.Concurrent;
 using System.Linq;
 using System.Threading.Tasks;
@@ -324,3 +324,4 @@ public async Task Teardown()
 
     ConcurrentDictionary<Ordinates, NpgsqlDataSource> NtsDataSources = new();
 }
+*/