fixup! feat(eap): Add email setup and template

Author: sudip-khanal

eap/tasks.py

@@ -30,15 +30,22 @@ def send_new_eap_registration_email(eap_registration_id: int):
         settings.EMAIL_EAP_DREF_ANTICIPATORY_PILLAR,
         instance.ifrc_contact_email,
     ]
-    cc_recipients = [
-        instance.national_society_contact_email,
-        *settings.EMAIL_EAP_DREF_AA_GLOBAL_TEAM,
-        *regional_coordinator_emails,
-    ]
+    cc_recipients = list(
+        set(
+            [
+                instance.national_society_contact_email,
+                *settings.EMAIL_EAP_DREF_AA_GLOBAL_TEAM,
+                *regional_coordinator_emails,
+            ]
+        )
+    )
     email_context = get_eap_registration_email_context(instance)
-    email_subject = f"[{instance.get_eap_type_display()} IN DEVELOPMENT] {instance.country} {instance.disaster_type}"
+    email_subject = (
+        f"[{instance.get_eap_type_display() if instance.get_eap_type_display() else 'EAP'} IN DEVELOPMENT] "
+        f"{instance.country} {instance.disaster_type}"
+    )
     email_body = render_to_string("email/eap/registration.html", email_context)
-    email_type = "EAP-REGISTRATION"
+    email_type = "New EAP Registration"
 
     send_notification(
         subject=email_subject,

eap/utils.py

@@ -47,7 +47,6 @@ def get_eap_registration_email_context(instance):
         "ns_contact_name": eap_registration_data["national_society_contact_name"],
         "ns_contact_email": eap_registration_data["national_society_contact_email"],
         "ns_contact_phone": eap_registration_data["national_society_contact_phone_number"],
-        "status_display": eap_registration_data["status_display"],
         "frontend_url": settings.GO_WEB_URL,
     }
     return email_context

notifications/templates/email/eap/re-submission.html

@@ -25,7 +25,7 @@
                         Type of EAP
                     </td>
                     <td style="border:1px solid #000000;">
-                        {{ eap_type_display }}
+                        {{ eap_type_display|default:"Not Sure" }}
                     </td>
                 </tr>
                 <tr>

notifications/templates/email/eap/registration.html

@@ -10,7 +10,7 @@
             </p>
             <p>
                 <span style="text-transform: uppercase; font-weight: bold;">{{ national_society }}</span>, wishes to inform the IFRC-DREF Team that has started to work on the development of an 
-                <span style="text-transform: uppercase; font-weight: bold;">{{ eap_type_display }}</span>.
+                <span style="text-transform: uppercase; font-weight: bold;"> {{ eap_type_display|default:"EAP" }}</span>.
             </p>
 
             <!-- Main data table -->
@@ -21,7 +21,7 @@
                 </tr>
                 <tr>
                     <td style="font-weight: bold;">Type of EAP</td>
-                    <td>{{ eap_type_display }}</td>
+                   <td> {{ eap_type_display|default:"Not Sure" }} </td>
                 </tr>
                 <tr>
                     <td style="font-weight: bold;">Hazard</td>
@@ -40,6 +40,7 @@
             </table>
 
             <!-- Signature -->
+             <p>You can check the progress of this EAP <a href="{{ frontend_url }}/eap-registration/{{ registration_id }}/">here.</a></p>
             <p style="margin-top:16px;">
                 Kind regards,<br>
                 {{ ns_contact_name }}<br>

notifications/templates/email/eap/submission.html

@@ -5,7 +5,7 @@
         <td style="line-height:1.6;">
             <p style="font-weight: bold;">Dear colleagues,</p>
             <p>
-                <span style="text-transform: uppercase; font-weight: bold;">{{ national_society }}</span> is hereby submiting the following {{ eap_type_display }}
+                <span style="text-transform: uppercase; font-weight: bold;">{{ national_society }}</span> is hereby submiting the following {{ eap_type_display|default:"Not Sure" }}
                 to the IFRC-DREF for technical review and approval:
             </p>
 
@@ -20,7 +20,7 @@
                 </tr>
                 <tr>
                     <td style="border:1px solid #000000; width:40%; font-weight: bold;">Type of EAP</td>
-                    <td style="border:1px solid #000000;">{{ eap_type_display }}</td>
+                    <td style="border:1px solid #000000;">{{ eap_type_display|default:"Not Sure" }}</td>
                 </tr>
                 <tr>
                     <td style="border:1px solid #000000; width:40%; font-weight: bold;">Hazard</td>