Skip to content

Commit a05fcc8

Browse files
committed
test(migration): update tests to account for additional workflow settings
Enhanced `V6_8_0_1__SettingsDataMigrationIT` to include tests for new workflow settings (`PrePublishDatasetWorkflowId` and `PostPublishDatasetWorkflowId`). Updated expected data assertions and display names for better clarity and completeness.
1 parent 58a1237 commit a05fcc8

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/test/java/edu/harvard/iq/dataverse/db/migration/V6_8_0_1__SettingsDataMigrationIT.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package edu.harvard.iq.dataverse.db.migration;
22

3-
3+
import edu.harvard.iq.dataverse.settings.SettingsServiceBean.Key;
44
import edu.harvard.iq.dataverse.util.testing.Tags;
55
import org.dbunit.IDatabaseTester;
66
import org.junit.jupiter.api.AfterEach;
@@ -63,14 +63,16 @@ void tearDown() throws Exception {
6363
}
6464

6565
@Test
66-
@DisplayName("Test migrating BuiltinUsers.KEY and WorkflowsAdmin")
66+
@DisplayName("Test migrating BuiltinUsers.KEY and Workflow settings")
6767
void testMigrationConvertSimpleSettings() throws Exception {
6868
// GIVEN
6969
var inputXml = """
7070
<?xml version='1.0' encoding='UTF-8'?>
7171
<dataset>
7272
<setting id="1" name="BuiltinUsers.KEY" content="secret-key-123" />
7373
<setting id="2" name="WorkflowsAdmin#IP_WHITELIST_KEY" content="127.0.0.1" />
74+
<setting id="3" name="WorkflowServiceBean.WorkflowId:PrePublishDataset" content="1" />
75+
<setting id="4" name="WorkflowServiceBean.WorkflowId:PostPublishDataset" content="2" />
7476
</dataset>
7577
""";
7678
DBUnitHelper.loadData(databaseTester, inputXml);
@@ -85,10 +87,12 @@ void testMigrationConvertSimpleSettings() throws Exception {
8587
var expectedXml = """
8688
<?xml version='1.0' encoding='UTF-8'?>
8789
<dataset>
88-
<setting name=":BuiltinUsersKey" content="secret-key-123" />
89-
<setting name=":WorkflowsAdminIpWhitelist" content="127.0.0.1" />
90+
<setting name="%s" content="secret-key-123" lang="[null]" />
91+
<setting name="%s" content="127.0.0.1" lang="[null]" />
92+
<setting name="%s" content="1" lang="[null]" />
93+
<setting name="%s" content="2" lang="[null]" />
9094
</dataset>
91-
""";
95+
""".formatted(Key.BuiltinUsersKey, Key.WorkflowsAdminIpWhitelist, Key.PrePublishDatasetWorkflowId, Key.PostPublishDatasetWorkflowId);
9296
var expectedData = DBUnitHelper.getExpectedData(expectedXml, TABLE_NAME, "name", "id");
9397

9498
DBUnitHelper.assertTablesEqual(expectedData, actualData);

0 commit comments

Comments
 (0)