raises unavailable

Author: pcrespov

services/payments/src/simcore_service_payments/_constants.py

@@ -6,4 +6,4 @@
 RUT: Final[str] = "Resource Usage Tracker service"
 
 
-MSG_GATEWAY_UNAVAILABLE_ERROR = "Our payments provider is temporary unavailable"
+MSG_GATEWAY_UNAVAILABLE_ERROR = "Our payments provider is temporary innoperative"

services/payments/src/simcore_service_payments/services/payments_gateway.py

@@ -94,7 +94,7 @@ def _reraise_as_service_errors_context(operation_id: str):
     except httpx.RequestError as err:
         _logger.exception("%s: request error", PAG)
         raise PaymentServiceUnavailableError(
-            human_reason=MSG_GATEWAY_UNAVAILABLE_ERROR
+            human_readable_detail=MSG_GATEWAY_UNAVAILABLE_ERROR
         ) from err
 
     except httpx.HTTPStatusError as err:
@@ -110,7 +110,7 @@ def _reraise_as_service_errors_context(operation_id: str):
             # 5XX in server -> turn into unavailable
             _logger.exception(error.get_detailed_message())
             raise PaymentServiceUnavailableError(
-                human_reason=MSG_GATEWAY_UNAVAILABLE_ERROR
+                human_readable_detail=MSG_GATEWAY_UNAVAILABLE_ERROR
             ) from err
 
 

services/payments/tests/unit/test_rpc_payments.py

@@ -98,13 +98,6 @@ async def test_rpc_init_payment_fail(
             timeout_s=None if is_pdb_enabled else 5,
         )
 
-    error = exc_info.value
-    assert isinstance(error, RPCServerError)
-    assert error.exc_type == "httpx.ConnectError"
-    assert error.method_name == "init_payment"
-    assert error.exc_message
-    assert error.traceback
-    # FIXME: should raise
     assert isinstance(exc_info.value, PaymentServiceUnavailableError)