Fix: Correct file exclusion logic in Compactor #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file exclusion logic in the BuildWorkingFilesList method was flawed. The condition incorrectly included files for compression if their full path was present in the exclusion list, which is intended for file extensions. This change corrects the LINQ query to ensure that files are excluded based on their extension as intended. A new test project and test case have been added to verify this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file exclusion logic in the BuildWorkingFilesList method was flawed. The condition incorrectly included files for compression if their full path was present in the exclusion list, which is intended for file extensions.
This change corrects the LINQ query to ensure that files are excluded based on their extension as intended. A new test project and test case have been added to verify this fix.