Correction after github checks

“Akshay · “Akshay · commit 38bfdfc5207c · 2025-11-25T08:40:11.000-08:00
diff --git a/iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java b/iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
@@ -691,14 +691,14 @@ int getVerticalLocation(Rect padding) {
      * Rounds an orientation value to the nearest 90-degree increment.
      * This is used to detect significant orientation changes (portrait/landscape).
      *
-     * The calculation uses integer division: ((orientation + 45) / 90) * 90
-     * This rounds to the nearest multiple of 90 by adding 45 before dividing.
+     * The calculation rounds to the nearest multiple of 90 by adding 45 before dividing.
+     * Uses floating point division to correctly handle negative numbers.
      *
      * @param orientation The orientation value in degrees (typically 0-359 from OrientationEventListener)
      * @return The orientation rounded to the nearest 90-degree increment (0, 90, 180, 270, or 360)
      */
     static int roundToNearest90Degrees(int orientation) {
-        return ((orientation + 45) / 90) * 90;
+        return (int) (Math.round((orientation + 45.0) / 90.0) * 90);
     }
 
     /**
diff --git a/iterableapi/src/test/java/com/iterable/iterableapi/IterableInAppHTMLNotificationTest.java b/iterableapi/src/test/java/com/iterable/iterableapi/IterableInAppHTMLNotificationTest.java
@@ -20,12 +20,6 @@
 import static junit.framework.Assert.assertEquals;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertTrue;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.Mockito.doCallRealMethod;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
 import static org.robolectric.Shadows.shadowOf;
 
 public class IterableInAppHTMLNotificationTest extends BaseTest {
@@ -146,7 +140,8 @@ public void testResizeValidation_HandlesGracefully() {
     public void testApplyWindowGravity_Center() {
         Rect padding = new Rect(0, -1, 0, -1); // Center padding
         IterableInAppFragmentHTMLNotification notification = IterableInAppFragmentHTMLNotification.createInstance(
-            "<html><body>Test</body></html>", false, uri -> {}, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
+            "<html><body>Test</body></html>", false, uri -> {
+            }, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
 
         // Verify gravity calculation for center padding
         assertEquals(Gravity.CENTER_VERTICAL, notification.getVerticalLocation(padding));
@@ -156,7 +151,8 @@ public void testApplyWindowGravity_Center() {
     public void testApplyWindowGravity_Top() {
         Rect padding = new Rect(0, 0, 0, -1); // Top padding
         IterableInAppFragmentHTMLNotification notification = IterableInAppFragmentHTMLNotification.createInstance(
-            "<html><body>Test</body></html>", false, uri -> {}, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
+            "<html><body>Test</body></html>", false, uri -> {
+            }, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
 
         assertEquals(Gravity.TOP, notification.getVerticalLocation(padding));
     }
@@ -165,7 +161,8 @@ public void testApplyWindowGravity_Top() {
     public void testApplyWindowGravity_Bottom() {
         Rect padding = new Rect(0, -1, 0, 0); // Bottom padding
         IterableInAppFragmentHTMLNotification notification = IterableInAppFragmentHTMLNotification.createInstance(
-            "<html><body>Test</body></html>", false, uri -> {}, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
+            "<html><body>Test</body></html>", false, uri -> {
+            }, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
 
         assertEquals(Gravity.BOTTOM, notification.getVerticalLocation(padding));
     }
@@ -174,8 +171,9 @@ public void testApplyWindowGravity_Bottom() {
     public void testApplyWindowGravity_HandlesNullWindow() {
         Rect padding = new Rect(0, 0, 0, -1);
         IterableInAppFragmentHTMLNotification notification = IterableInAppFragmentHTMLNotification.createInstance(
-            "<html><body>Test</body></html>", false, uri -> {}, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
-        
+            "<html><body>Test</body></html>", false, uri -> {
+            }, IterableInAppLocation.IN_APP, "msg1", 0.0, padding, false, new IterableInAppMessage.InAppBgColor(null, 0.0f));
+
         // Test that getVerticalLocation works correctly
         assertEquals(Gravity.TOP, notification.getVerticalLocation(padding));
         // applyWindowGravity is private but is called in onStart/onCreateDialog/onCreateView
@@ -235,7 +233,7 @@ public void testLayoutStructure_FullScreenNoRelativeLayoutWrapper() {
         assertTrue("Root view should have children", rootView.getChildCount() > 0);
         ViewGroup child = (ViewGroup) rootView.getChildAt(0);
         // WebView is not a ViewGroup, so we check it's not a RelativeLayout
-        assertTrue("First child should be WebView (not RelativeLayout) for full screen in-apps", 
+        assertTrue("First child should be WebView (not RelativeLayout) for full screen in-apps",
             !(child instanceof RelativeLayout));
     }
 
@@ -300,7 +298,7 @@ public void testOrientationChange_PortraitToLandscape() throws Exception {
         // The test passes if no exceptions are thrown and the resize was triggered
         // We verify indirectly by ensuring the notification still exists and is in a valid state
         assertNotNull("Notification should still exist after orientation change", notification);
-        
+
         // The resize should have been triggered (1500ms delay + 200ms debounce)
         // If runResizeScript wasn't called, we would have seen validation errors or exceptions
         // The fact that we get here without exceptions means the orientation change handling worked
@@ -326,23 +324,23 @@ public void testRoundToNearest90Degrees_StandardOrientations() {
     public void testRoundToNearest90Degrees_BoundaryValues() {
         // Values that round down to 0 (0-44)
         assertEquals(0, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(44));
-        
+
         // Values that round up to 90 (45-134)
         assertEquals(90, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(45));
         assertEquals(90, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(89));
         assertEquals(90, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(90));
         assertEquals(90, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(134));
-        
+
         // Values that round up to 180 (135-224)
         assertEquals(180, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(135));
         assertEquals(180, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(180));
         assertEquals(180, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(224));
-        
+
         // Values that round up to 270 (225-314)
         assertEquals(270, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(225));
         assertEquals(270, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(270));
         assertEquals(270, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(314));
-        
+
         // Values that round up to 360 (315-359)
         assertEquals(360, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(315));
         assertEquals(360, IterableInAppFragmentHTMLNotification.roundToNearest90Degrees(359));
diff --git a/iterableapi/src/test/java/com/iterable/iterableapi/IterableWebChromeClientTest.java b/iterableapi/src/test/java/com/iterable/iterableapi/IterableWebChromeClientTest.java
@@ -4,14 +4,11 @@
 
 import org.junit.Before;
 import org.junit.Test;
-import org.mockito.ArgumentCaptor;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 
-import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 

Original file line number	Diff line number	Diff line change
`@@ -691,14 +691,14 @@ int getVerticalLocation(Rect padding) {`
`691`	`691`	`* Rounds an orientation value to the nearest 90-degree increment.`
`692`	`692`	`* This is used to detect significant orientation changes (portrait/landscape).`
`693`	`693`	`*`
`694`		`- * The calculation uses integer division: ((orientation + 45) / 90) * 90`
`695`		`- * This rounds to the nearest multiple of 90 by adding 45 before dividing.`
	`694`	`+ * The calculation rounds to the nearest multiple of 90 by adding 45 before dividing.`
	`695`	`+ * Uses floating point division to correctly handle negative numbers.`
`696`	`696`	`*`
`697`	`697`	`* @param orientation The orientation value in degrees (typically 0-359 from OrientationEventListener)`
`698`	`698`	`* @return The orientation rounded to the nearest 90-degree increment (0, 90, 180, 270, or 360)`
`699`	`699`	`*/`
`700`	`700`	`static int roundToNearest90Degrees(int orientation) {`
`701`		`- return ((orientation + 45) / 90) * 90;`
	`701`	`+ return (int) (Math.round((orientation + 45.0) / 90.0) * 90);`
`702`	`702`	`}`
`703`	`703`
`704`	`704`	`/**`