-
Notifications
You must be signed in to change notification settings - Fork 49
H2 Development Branch #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kdorheim
wants to merge
24
commits into
dev
Choose a base branch
from
dev-h2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose oh lifetime or oh tau to R bindings so it is easy to fetch output, add H2 unit testing, and expose R bindings.
…rs in the gcam coupling
…ead in from teh ini file
* Implement the H2 effects on CH4 lifetime with respect to OH. * Change the CH4_LIFETIME_OH R function to be more descriptive
Add the H2 emission contribution to the stratospheric H2O vapor.
Change how the H2 effects on tau OH is implemented so that now the H2 coefficient varies with the CO coefficient.
(1) Use the value from Sand et al. 2023 ST4 for the H2 emission coefficient for the strat. H2O water vapor forcing. This prevents double-counting forcing effects from CH4. (2) Use consistent formatting to cite the Sand et al. 2023 parameters used in hector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, this PR will incorporate the climate effects of H2 emissions into Hector's radiative forcing calculations. Multiple branches/PRs will be merged here before it is ready to be merged into dev and ready for a model release.
Issues
no* - indicates that there is no change in the old-new test data because$H{_2}$ emissions are set to 0 at the