Changed the order of creation of clonedRelation. The way it was, it was not doing/testing anything.

Author: PolyglotOpenstreetmap

test/unit/org/openstreetmap/josm/plugins/pt_assistant/data/RouteSegmentToExtractTest.java

@@ -2560,22 +2560,23 @@ public void testPtLine(List<Val> expectedValues, int relationId) {
         Relation busRouteRelation = getRelationForId(relationId, allRelations);
 
         assertNotNull(busRouteRelation);
-        RouteSegmentToExtract segment = new RouteSegmentToExtract(busRouteRelation);
+
+        Relation clonedRelation = new Relation(busRouteRelation);
+
+        RouteSegmentToExtract segment = new RouteSegmentToExtract(clonedRelation);
         segment.setActiveDataSet(ds);
 
-        assertEquals(busRouteRelation.get("ref"), segment.getLineIdentifiersSignature());
-        assertEquals(busRouteRelation.get("colour"), segment.getColoursSignature());
+        assertEquals(clonedRelation.get("ref"), segment.getLineIdentifiersSignature());
+        assertEquals(clonedRelation.get("colour"), segment.getColoursSignature());
 
         assertNull(segment.extractToRelation(Collections.emptyList(), false));
 
         assertEquals("", segment.getWayIdsSignature());
         assertEquals(Collections.emptyList(), segment.getWayMembers());
-        System.out.printf("***** %s *****\n\n     ", busRouteRelation.get("name"));
+        System.out.printf("***** %s *****\n\n     ", clonedRelation.get("name"));
 
         RouteSegmentToExtract previousSegment = segment;
 
-        Relation clonedRelation = new Relation(busRouteRelation);
-
         for (Val v: expectedValues) {
             segment = previousSegment.addPTWayMember(v.index);
             if (segment != null) {