fix some invalidations caused by FixedPointNumbers (#448)

* fix some invalidations caused by FixedPointNumbers

* another invalidation

Co-authored-by: Chris Elrod <[email protected]>

Author: ranocha

src/modeling/graphs.jl

@@ -834,7 +834,8 @@ function add_constant_compute!(ls::LoopSet, op::Operation, var::Symbol)::Operati
     if !getconstfailed
       f = instr.instr
       if f === :add_fast
-        return add_constant!(ls, sum(vals), 8)::Operation
+        # use init explicitly to prevent invalidations
+        return add_constant!(ls, sum(vals; init = false), 8)::Operation
       elseif f === :mul_fast
         return add_constant!(ls, prod(vals), 8)::Operation
       elseif f === :sub_fast
@@ -848,7 +849,8 @@ function add_constant_compute!(ls::LoopSet, op::Operation, var::Symbol)::Operati
           return add_constant!(ls, vals[1] / vals[2], 8)::Operation
         end
       elseif length(opparents) == 3
-        T = typeof(sum(vals))
+        # use init explicitly to prevent invalidations
+        T = typeof(sum(vals; init = false))
         if f === :vfmadd_fast
           return add_constant!(
             ls,

src/parse/memory_ops_common.jl

@@ -859,7 +859,8 @@ function array_reference_meta!(
         addconstindex!(indices, offsets, strides, loopedindex, ind)
         ninds += 1
       else
-        vptrarray = subset_vptr!(ls, vptrarray, ninds, ind, indices, loopedindex, 0)
+        # convert ind to reduce invalidations
+        vptrarray = subset_vptr!(ls, vptrarray, ninds, convert(Int, ind), indices, loopedindex, 0)
         length(indices) == 0 && push!(indices, DISCONTIGUOUS)
       end
     elseif ind isa Expr