Fix rebase issues and warnings on latest msvc

Author: seanharmer

.clang-tidy

@@ -1,56 +1,56 @@
 ---
 Checks: '*,
-clang-analyzer-*,
-clang-diagnostic-*,
--abseil-*,
--altera-*,
--android-*,
--boost-use-ranges,
--bugprone-branch-clone,
--bugprone-easily-swappable-parameters,
--bugprone-suspicious-include,
--clang-analyzer-alpha.core.CastToStruct,
--clang-analyzer-alpha.deadcode.UnreachableCode,
--clang-analyzer-alpha*,
--clang-analyzer-core.CallAndMessage,
--clang-analyzer-core.NonNullParamChecker,
--clang-analyzer-cplusplus.NewDeleteLeaks,
--clang-analyzer-optin.core.EnumCastOutOfRange,
--clang-diagnostic-gnu-zero-variadic-macro-arguments,
--cppcoreguidelines-*,
--fuchsia-*,
--google-*,
--hicpp-*,
--llvm-*,
--llvm-include-order,
--llvm-namespace-comment,
--llvmlibc-*,
--misc-include-cleaner,
--misc-no-recursion,
--misc-non-private-member-variables-in-classes,
--modernize-loop-convert,
--modernize-pass-by-value,
--modernize-raw-string-literal,
--modernize-return-braced-init-list,
--modernize-use-bool-literals,
--modernize-use-default-member-init,
--modernize-use-default,
--modernize-use-emplace,
--modernize-use-equals-default,
--modernize-use-override,
--modernize-use-trailing-return-type,
--modernize-use-using,
--readability-braces-around-statements,
--readability-else-after-return,
--readability-function-cognitive-complexity,
--readability-identifier-length,
--readability-implicit-bool-cast,
--readability-implicit-bool-conversion,
--readability-magic-numbers,
--readability-named-parameter,
--readability-qualified-auto,
--readability-uppercase-literal-suffix,
--readabilty-namespace-comments'
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  -abseil-*,
+  -altera-*,
+  -android-*,
+  -boost-use-ranges,
+  -bugprone-branch-clone,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-suspicious-include,
+  -clang-analyzer-alpha.core.CastToStruct,
+  -clang-analyzer-alpha.deadcode.UnreachableCode,
+  -clang-analyzer-alpha*,
+  -clang-analyzer-core.CallAndMessage,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  -clang-analyzer-optin.core.EnumCastOutOfRange,
+  -clang-diagnostic-gnu-zero-variadic-macro-arguments,
+  -cppcoreguidelines-*,
+  -fuchsia-*,
+  -google-*,
+  -hicpp-*,
+  -llvm-*,
+  -llvm-include-order,
+  -llvm-namespace-comment,
+  -llvmlibc-*,
+  -misc-include-cleaner,
+  -misc-no-recursion,
+  -misc-non-private-member-variables-in-classes,
+  -modernize-loop-convert,
+  -modernize-pass-by-value,
+  -modernize-raw-string-literal,
+  -modernize-return-braced-init-list,
+  -modernize-use-bool-literals,
+  -modernize-use-default-member-init,
+  -modernize-use-default,
+  -modernize-use-emplace,
+  -modernize-use-equals-default,
+  -modernize-use-override,
+  -modernize-use-trailing-return-type,
+  -modernize-use-using,
+  -readability-braces-around-statements,
+  -readability-else-after-return,
+  -readability-function-cognitive-complexity,
+  -readability-identifier-length,
+  -readability-implicit-bool-cast,
+  -readability-implicit-bool-conversion,
+  -readability-magic-numbers,
+  -readability-named-parameter,
+  -readability-qualified-auto,
+  -readability-uppercase-literal-suffix,
+  -readabilty-namespace-comments'
 WarningsAsErrors: ''
 CheckOptions:
   - key:             cert-oop11-cpp.UseCERTSemantics

src/KDNetwork/tcp_server.cpp

@@ -334,6 +334,9 @@ void TcpServer::onIncomingConnection()
         }
         return; // Wait for next incoming connection
     }
+
+    // Creating a socket for the new connection
+    auto newSocket = std::make_unique<TcpSocket>(static_cast<int>(clientFd), Socket::State::Connected);
 #else
     const int clientFd = accept(m_listeningFd, reinterpret_cast<struct sockaddr *>(&clientAddr), &clientAddrLen);
     if (clientFd < 0) {
@@ -343,10 +346,10 @@ void TcpServer::onIncomingConnection()
         }
         return; // Wait for next incoming connection
     }
-#endif
 
     // Creating a socket for the new connection
     auto newSocket = std::make_unique<TcpSocket>(clientFd, Socket::State::Connected);
+#endif
 
     // Call the callback with the new socket
     if (m_newConnectionCallback) {

tests/auto/foundation/event_queue/tst_event_queue.cpp

@@ -28,7 +28,6 @@ static_assert(!std::is_copy_assignable<EventQueue>{});
 static_assert(!std::is_move_constructible<EventQueue>{});
 static_assert(!std::is_move_assignable<EventQueue>{});
 
-namespace {
 class MyEvent : public Event
 {
 public:

tests/auto/network/tcp_socket/tst_tcp_socket.cpp

@@ -313,13 +313,13 @@ class TestTcpServer
         socklen_t addrLen = sizeof(clientAddr);
 
 #if defined(KD_PLATFORM_WIN32)
-        const auto clientFd = accept(m_socket.socketFileDescriptor(),
-                                     reinterpret_cast<struct sockaddr *>(&clientAddr),
-                                     &addrLen);
+        const SOCKET clientFd = accept(m_socket.socketFileDescriptor(),
+                                       reinterpret_cast<struct sockaddr *>(&clientAddr),
+                                       &addrLen);
 
         if (clientFd != INVALID_SOCKET) {
             // Create a new client socket using the accepted file descriptor
-            auto clientSocket = std::make_unique<TcpSocket>(clientFd, Socket::State::Connected);
+            auto clientSocket = std::make_unique<TcpSocket>(static_cast<int>(clientFd), Socket::State::Connected);
 
             // Store the client socket and notify
             TcpSocket *rawPtr = clientSocket.get();