Skip to content

Fix PositiveShaderObject.DrawWithBinaryShaders on 32-bit machines #10914

@spencer-lunarg

Description

@spencer-lunarg

@artem-lunarg I decided to just put the test on the 32-bit blacklist, but we should just fix it properly

the current code has

        size_t data_size;
        vk::GetShaderBinaryDataEXT(*m_device, shaders[i], &data_size, nullptr);
        std::vector<uint8_t> data(data_size);
        vk::GetShaderBinaryDataEXT(*m_device, shaders[i], &data_size, data.data());

the issue is data.data() is sometimes not 16 byte aligned, which it needs to be

we just need a solution to enforce it, then run with https://github.com/LunarG/VulkanTests/pull/805 to ensure it works

Metadata

Metadata

Assignees

Labels

CI/TestsAnything related to CI or testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions